Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2884683003: mash: Remove WmWindow usage from ash/system/web_notification (Closed)

Created:
3 years, 7 months ago by James Cook
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, groby+bubble_chromium.org, sadrul, tfarina, hcarmona+bubble_chromium.org, kalyank, rouslan+bubble_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Remove WmWindow usage from ash/system/web_notification It's left over from the early mustash days and we don't need it anymore. BUG=722552 TEST=ash_unittests, manually open/close the notification tray Review-Url: https://codereview.chromium.org/2884683003 Cr-Commit-Position: refs/heads/master@{#472002} Committed: https://chromium.googlesource.com/chromium/src/+/8241d54464fb1b80960f65ed9e6a4315f94ad64e

Patch Set 1 #

Patch Set 2 : fix comment #

Total comments: 3

Patch Set 3 : curlies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M ash/system/status_area_widget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 4 chunks +12 lines, -10 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 5 chunks +7 lines, -13 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
msw, please take a look.
3 years, 7 months ago (2017-05-15 22:45:24 UTC) #4
msw
lgtm https://codereview.chromium.org/2884683003/diff/20001/ash/system/web_notification/web_notification_tray.cc File ash/system/web_notification/web_notification_tray.cc (right): https://codereview.chromium.org/2884683003/diff/20001/ash/system/web_notification/web_notification_tray.cc#newcode339 ash/system/web_notification/web_notification_tray.cc:339: if (shelf()->IsHorizontalAlignment()) { nit: curlies not needed https://codereview.chromium.org/2884683003/diff/20001/ui/views/bubble/tray_bubble_view.h ...
3 years, 7 months ago (2017-05-15 22:50:11 UTC) #5
James Cook
Thanks for the quick review. https://codereview.chromium.org/2884683003/diff/20001/ash/system/web_notification/web_notification_tray.cc File ash/system/web_notification/web_notification_tray.cc (right): https://codereview.chromium.org/2884683003/diff/20001/ash/system/web_notification/web_notification_tray.cc#newcode339 ash/system/web_notification/web_notification_tray.cc:339: if (shelf()->IsHorizontalAlignment()) { On ...
3 years, 7 months ago (2017-05-16 00:24:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884683003/40001
3 years, 7 months ago (2017-05-16 00:26:06 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 03:33:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8241d54464fb1b80960f65ed9e6a...

Powered by Google App Engine
This is Rietveld 408576698