Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2884643003: Rename android-webview-shell to android-webview-instrumentation (Closed)

Created:
3 years, 7 months ago by Shimi Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, piman+watch_chromium.org, sgurun-gerrit only, zmo1, Ken Russell (switch to Gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename android-webview-shell to android-webview-instrumentation This CL is a follow up of crrev/2878493003. Since we are renaming AndroidWebView.apk to WebViewInstrumentation.apk, it doesn't make sense we still call the corresponding enty android-webview-shell, so it is better to change this name as well. BUG=701938 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2884643003 Cr-Commit-Position: refs/heads/master@{#471924} Committed: https://chromium.googlesource.com/chromium/src/+/25d1b2958dad54c9310305dad0218c8f3fdbef98

Patch Set 1 #

Patch Set 2 : format change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M content/test/gpu/gpu_tests/test_expectations.py View 3 chunks +5 lines, -5 lines 0 comments Download
M content/test/gpu/gpu_tests/test_expectations_unittest.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 chunks +8 lines, -7 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Shimi Zhang
nednguyen@, PTAL, thanks!
3 years, 7 months ago (2017-05-15 20:23:14 UTC) #8
nednguyen
lgtm but I am don't have ownership in tools/chrome_proxy/
3 years, 7 months ago (2017-05-15 20:26:11 UTC) #9
Shimi Zhang
+bustamante@ for tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py, PTAL, thanks!
3 years, 7 months ago (2017-05-15 20:28:32 UTC) #11
bustamante
lgtm, thanks for checking!
3 years, 7 months ago (2017-05-15 20:32:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884643003/20001
3 years, 7 months ago (2017-05-15 22:12:11 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 22:28:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25d1b2958dad54c9310305dad021...

Powered by Google App Engine
This is Rietveld 408576698