Replace LayoutTableCell::AbsoluteColumnIndex() with EffectiveColumnIndex()

Replace LayoutTableCell::AbsoluteColumnIndex() with EffectiveColumnIndex()

We never use LayoutTableCell::AbsoluteColumnIndex() without converting
it to effective column index. Replace it with EffectiveColumnIndex()
to simplify callers.

Also add EffectiveColumnIndexOfAfterCell() and ColElement() to reduce
duplicated code, and replace LayoutTable::ColElementAtAbsoluteColumn()
with LayoutTable::ColElementAtEffectiveColumn().

BTW fixed several bugs that effective column index was passed to
LayoutTable::ColElementAtAbsoluteColumn().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[Xianzhu, 2017-05-15 05:58:35]

Description was changed from

==========
Replace LayoutTableCell::AbsoluteColumnIndex() with EffectiveColumnIndex()

We never use LayoutTableCell::AbsoluteColumnIndex() without converting
it to effective column index. Replace it with EffectiveColumnIndex()
to simplify callers.

Also add EffectiveColumnIndexOfAfterCell() and ColElement() to reduce
duplicated code, and replace LayoutTable::ColElementAtAbsoluteColumn()
with LayoutTable::ColElementAtEffectiveColumn().

BTW fixed several bugs that effective column index was passed to
LayoutTable::ColElementAtAbsoluteColumn().
==========

to

==========
Replace LayoutTableCell::AbsoluteColumnIndex() with EffectiveColumnIndex()

We never use LayoutTableCell::AbsoluteColumnIndex() without converting
it to effective column index. Replace it with EffectiveColumnIndex()
to simplify callers.

Also add EffectiveColumnIndexOfAfterCell() and ColElement() to reduce
duplicated code, and replace LayoutTable::ColElementAtAbsoluteColumn()
with LayoutTable::ColElementAtEffectiveColumn().

BTW fixed several bugs that effective column index was passed to
LayoutTable::ColElementAtAbsoluteColumn().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-05-15 06:03:46]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 06:04:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 07:16:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 07:16:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2017-05-15 16:38:25]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 16:39:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-15 18:36:33]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-05-15 18:36:44]

wangxianzhu@chromium.org changed reviewers:
+ dgrogan@chromium.org, eae@chromium.org

[commit-bot: I haz the power, 2017-05-15 18:37:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2017-05-15 18:38:15]

This is great, please allow dgrogan to comment before landing though.

LGTM

[commit-bot: I haz the power, 2017-05-15 20:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 20:48:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-05-16 00:24:49]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 00:26:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:52:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-16 15:53:42]

dgrogan@, would you like to take a look?

[dgrogan, 2017-05-16 16:55:43]

On 2017/05/16 15:53:42, Xianzhu wrote:
> dgrogan@, would you like to take a look?

Yes, sorry to hold you up. Embarrassing question from glancing at the new tests
though: what is an "outer" border? Is there such thing as an "inner" border?

[Xianzhu, 2017-05-16 17:08:35]

On 2017/05/16 16:55:43, dgrogan wrote:
> On 2017/05/16 15:53:42, Xianzhu wrote:
> > dgrogan@, would you like to take a look?
> 
> Yes, sorry to hold you up. Embarrassing question from glancing at the new
tests
> though: what is an "outer" border? Is there such thing as an "inner" border?

Yes there is "inner border". The concepts are applicable when a table collapses
borders.

In this example:
 <table style="border-collapse: collapse">
   <tr><td style="border: 10px solid"></td></tr>
 </table>
for the 10px border specified on the td, the inner 5px belongs to the td as the
td's border, the outer 5px belongs to the table as the table's border.

I have an WIP patch (not uploaded yet) to simplify outer border calculation and
also make the names more understandable.

These CLs are all towards fixing the old painting bugs of collapsed borders.

[Xianzhu, 2017-05-16 17:19:08]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 17:20:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:25:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:25:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-05-17 00:46:34]

I added LayoutTableSectionTest.OuterBorder* because I changed the related
functions which previously mistakenly called
ColElementAtAbsoluteColumn(effective_column_index). However, the related code
will be removed in https://codereview.chromium.org/2890543002/, so I removed the
tests from this CL.

[Xianzhu, 2017-05-17 05:03:41]

Sorry, I just noticed a big problem of this CL: I forgot to update
LayoutTable::ColElementAtEffectiveColumn() so it is actually still
ColElementAtAbsoluteColumn() just with a different name.

Will update and add test. Will let you know when I finish.

[Xianzhu, 2017-05-22 05:47:15]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 05:47:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-22 06:12:14]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 06:12:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-22 06:21:18]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 06:21:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 08:18:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 08:18:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-06-13 16:37:15]

Description was changed from

==========
Replace LayoutTableCell::AbsoluteColumnIndex() with EffectiveColumnIndex()

We never use LayoutTableCell::AbsoluteColumnIndex() without converting
it to effective column index. Replace it with EffectiveColumnIndex()
to simplify callers.

Also add EffectiveColumnIndexOfAfterCell() and ColElement() to reduce
duplicated code, and replace LayoutTable::ColElementAtAbsoluteColumn()
with LayoutTable::ColElementAtEffectiveColumn().

BTW fixed several bugs that effective column index was passed to
LayoutTable::ColElementAtAbsoluteColumn().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Replace LayoutTableCell::AbsoluteColumnIndex() with EffectiveColumnIndex()

We never use LayoutTableCell::AbsoluteColumnIndex() without converting
it to effective column index. Replace it with EffectiveColumnIndex()
to simplify callers.

Also add EffectiveColumnIndexOfAfterCell() and ColElement() to reduce
duplicated code, and replace LayoutTable::ColElementAtAbsoluteColumn()
with LayoutTable::ColElementAtEffectiveColumn().

BTW fixed several bugs that effective column index was passed to
LayoutTable::ColElementAtAbsoluteColumn().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========