Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXTable.cpp

Issue 2884573002: Replace LayoutTableCell::AbsoluteColumnIndex() with EffectiveColumnIndex()
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXTable.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXTable.cpp b/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
index 2c0f80c225caa2fee2ca2f7031ddccf25a8c00e5..a75e2d9b6f08c2513b200eb59f7df7fc9f5a7f59 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
@@ -165,7 +165,7 @@ bool AXTable::IsDataTable() const {
if (!first_body)
return false;
- int num_cols_in_first_body = first_body->NumEffectiveColumns();
+ int num_cols_in_first_body = first_body->MaxNumEffectiveColumnsOfRows();
int num_rows = first_body->NumRows();
// If there's only one cell, it's not a good AXTable candidate.
@@ -204,7 +204,7 @@ bool AXTable::IsDataTable() const {
int headers_in_first_column_count = 0;
for (int row = 0; row < num_rows; ++row) {
int headers_in_first_row_count = 0;
- int n_cols = first_body->NumCols(row);
+ int n_cols = first_body->NumEffectiveColumns(row);
for (int col = 0; col < n_cols; ++col) {
LayoutTableCell* cell = first_body->PrimaryCellAt(row, col);
if (!cell)
@@ -429,7 +429,7 @@ void AXTable::AddChildren() {
}
// make the columns based on the number of columns in the first body
- unsigned length = initial_table_section->NumEffectiveColumns();
+ unsigned length = initial_table_section->MaxNumEffectiveColumnsOfRows();
for (unsigned i = 0; i < length; ++i) {
AXTableColumn* column = ToAXTableColumn(ax_cache.GetOrCreate(kColumnRole));
column->SetColumnIndex((int)i);

Powered by Google App Engine
This is Rietveld 408576698