Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2884563004: cc: Renamed approximate{BytesUsed,OpCount} in paint op buffer. (Closed)

Created:
3 years, 7 months ago by vmpstr
Modified:
3 years, 7 months ago
Reviewers:
danakj, pdr., enne (OOO)
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Renamed approximate{BytesUsed,OpCount} in paint op buffer. This patch changes the names of functions as follows: PaintOpBuffer::approximateBytesUsed -> bytes_used PaintOpBuffer::approximateOpCount -> size Also changes related functions in other classes where appropriate. Also changes the return type of new size function to be size_t. R=enne@chromium.org, danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2884563004 Cr-Commit-Position: refs/heads/master@{#472259} Committed: https://chromium.googlesource.com/chromium/src/+/4cbf5c87956f29d3107b2228d14bb8c402dc2d24

Patch Set 1 #

Patch Set 2 : winfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M cc/layers/recording_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/clip_display_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/paint/clip_path_display_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/paint/compositing_display_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/paint/display_item_list.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/paint/display_item_list.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/paint/display_item_list_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/paint/drawing_display_item.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/drawing_display_item.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/paint/filter_display_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/paint/float_clip_display_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/paint/paint_op_buffer.h View 1 6 chunks +13 lines, -11 lines 0 comments Download
M cc/paint/paint_op_buffer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/paint/paint_op_buffer_unittest.cc View 1 8 chunks +12 lines, -12 lines 0 comments Download
M cc/paint/transform_display_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
vmpstr
Please take a look.
3 years, 7 months ago (2017-05-15 23:24:45 UTC) #3
danakj
LGTM
3 years, 7 months ago (2017-05-15 23:28:31 UTC) #4
enne (OOO)
Thank you! lgtm
3 years, 7 months ago (2017-05-15 23:34:55 UTC) #5
vmpstr
+pdr for blink, please take a look.
3 years, 7 months ago (2017-05-16 14:51:57 UTC) #9
pdr.
lgtm
3 years, 7 months ago (2017-05-16 15:40:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563004/1
3 years, 7 months ago (2017-05-16 16:11:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/412474)
3 years, 7 months ago (2017-05-16 16:55:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563004/20001
3 years, 7 months ago (2017-05-16 17:00:32 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/456213)
3 years, 7 months ago (2017-05-16 19:51:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563004/20001
3 years, 7 months ago (2017-05-16 21:07:57 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:19:53 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cbf5c87956f29d3107b2228d14b...

Powered by Google App Engine
This is Rietveld 408576698