Don't require user action for active scripts for component or policy exts

extensions/common/permissions/permissions_data.cc

Index: extensions/common/permissions/permissions_data.cc
diff --git a/extensions/common/permissions/permissions_data.cc b/extensions/common/permissions/permissions_data.cc
index 809865d46fafd862e15bff12e07a6504ab3331b7..65acfecf982f2d9397b976cd8b3578195fe09620 100644
--- a/extensions/common/permissions/permissions_data.cc
+++ b/extensions/common/permissions/permissions_data.cc
@@ -564,8 +564,13 @@ bool PermissionsData::CanCaptureVisiblePage(const Extension* extension,
 bool PermissionsData::RequiresActionForScriptExecution(
     const Extension* extension) {
   // For now, the user should be notified when an extension with all hosts
-  // permission tries to execute a script on a page.
-  return HasEffectiveAccessToAllHosts(extension);
+  // permission tries to execute a script on a page. Exceptions for policy-
+  // enabled and component extensions.
+  return extension->location() != Manifest::EXTERNAL_POLICY_DOWNLOAD &&

[Devlin, 2014/05/12 23:05:09]

Should we also do Manifest::IsUnpackedLocation() here?

[not at google - send to devlin, 2014/05/13 00:00:16]

I was wondering the same thing before -- and I think no. It's misleading to
developers to behave differently in development vs release. When we have the
prefs checkbox to turn this off, developers can just do that.

+         extension->location() != Manifest::EXTERNAL_POLICY &&
+         extension->location() != Manifest::COMPONENT &&
+         extension->location() != Manifest::EXTERNAL_COMPONENT &&

[not at google - send to devlin, 2014/05/13 00:00:16]

At a higher level this:
- shouldn't include extensions that don't appear in chrome://extensions (use
ShouldDisplayInExtensionSettings)
- shouldn't include policy obviously. 

[Devlin, 2014/05/13 17:03:03]

Are there any policy ones, other than EXTERNAL_POLICY[_DOWNLOAD]?

+         HasEffectiveAccessToAllHosts(extension);
 }
 
 bool PermissionsData::ParsePermissions(Extension* extension,