Don't require user action for active scripts for component or policy exts

extensions/common/permissions/permissions_data.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/permissions/permissions_data.h"
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 546 matching lines @@
 
   if (error)
     *error = errors::kAllURLOrActiveTabNeeded;
   return false;
 }
 
 // static
 bool PermissionsData::RequiresActionForScriptExecution(
     const Extension* extension) {
   // For now, the user should be notified when an extension with all hosts
-  // permission tries to execute a script on a page.
-  return HasEffectiveAccessToAllHosts(extension);
+  // permission tries to execute a script on a page. Exceptions for policy-
+  // enabled and component extensions.
+  return extension->location() != Manifest::EXTERNAL_POLICY_DOWNLOAD &&

[Devlin, 2014/05/12 23:05:09]

Should we also do Manifest::IsUnpackedLocation() here?

[not at google - send to devlin, 2014/05/13 00:00:16]

I was wondering the same thing before -- and I think no. It's misleading to
developers to behave differently in development vs release. When we have the
prefs checkbox to turn this off, developers can just do that.

+         extension->location() != Manifest::EXTERNAL_POLICY &&
+         extension->location() != Manifest::COMPONENT &&
+         extension->location() != Manifest::EXTERNAL_COMPONENT &&

[not at google - send to devlin, 2014/05/13 00:00:16]

At a higher level this:
- shouldn't include extensions that don't appear in chrome://extensions (use
ShouldDisplayInExtensionSettings)
- shouldn't include policy obviously. 

[Devlin, 2014/05/13 17:03:03]

Are there any policy ones, other than EXTERNAL_POLICY[_DOWNLOAD]?

+         HasEffectiveAccessToAllHosts(extension);
 }
 
 bool PermissionsData::ParsePermissions(Extension* extension,
                                        base::string16* error) {
   initial_required_permissions_.reset(new InitialPermissions);
   if (!ParseHelper(extension,
                    keys::kPermissions,
                    &initial_required_permissions_->api_permissions,
                    &initial_required_permissions_->host_permissions,
                    error)) {
@@ skipping 34 matching lines @@
       initial_optional_permissions_->api_permissions,
       initial_optional_permissions_->manifest_permissions,
       initial_optional_permissions_->host_permissions,
       URLPatternSet());
 
   initial_required_permissions_.reset();
   initial_optional_permissions_.reset();
 }
 
 }  // namespace extensions