Don't require user action for active scripts for component or policy exts

Don't require user action for active scripts for component or policy exts

BUG=372243
BUG=362353
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270181

[Devlin, 2014-05-12 23:05:08]

https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
File extensions/common/permissions/permissions_data.cc (right):

https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
extensions/common/permissions/permissions_data.cc:569: return
extension->location() != Manifest::EXTERNAL_POLICY_DOWNLOAD &&
Should we also do Manifest::IsUnpackedLocation() here?

[not at google - send to devlin, 2014-05-13 00:00:16]

lgtm

https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
File extensions/common/permissions/permissions_data.cc (right):

https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
extensions/common/permissions/permissions_data.cc:569: return
extension->location() != Manifest::EXTERNAL_POLICY_DOWNLOAD &&
On 2014/05/12 23:05:09, D Cronin wrote:
> Should we also do Manifest::IsUnpackedLocation() here?

I was wondering the same thing before -- and I think no. It's misleading to
developers to behave differently in development vs release. When we have the
prefs checkbox to turn this off, developers can just do that.

https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
extensions/common/permissions/permissions_data.cc:572: extension->location() !=
Manifest::EXTERNAL_COMPONENT &&
At a higher level this:
- shouldn't include extensions that don't appear in chrome://extensions (use
ShouldDisplayInExtensionSettings)
- shouldn't include policy obviously.

[Devlin, 2014-05-13 17:03:03]

https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
File extensions/common/permissions/permissions_data.cc (right):

https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
extensions/common/permissions/permissions_data.cc:572: extension->location() !=
Manifest::EXTERNAL_COMPONENT &&
On 2014/05/13 00:00:16, kalman wrote:
> At a higher level this:
> - shouldn't include extensions that don't appear in chrome://extensions (use
> ShouldDisplayInExtensionSettings)
> - shouldn't include policy obviously. 

Are there any policy ones, other than EXTERNAL_POLICY[_DOWNLOAD]?

[not at google - send to devlin, 2014-05-13 17:06:44]

On 2014/05/13 17:03:03, D Cronin wrote:
>
https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
> File extensions/common/permissions/permissions_data.cc (right):
> 
>
https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
> extensions/common/permissions/permissions_data.cc:572: extension->location()
!=
> Manifest::EXTERNAL_COMPONENT &&
> On 2014/05/13 00:00:16, kalman wrote:
> > At a higher level this:
> > - shouldn't include extensions that don't appear in chrome://extensions (use
> > ShouldDisplayInExtensionSettings)
> > - shouldn't include policy obviously. 
> 
> Are there any policy ones, other than EXTERNAL_POLICY[_DOWNLOAD]?

Nope:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

But you could check Manifest::IsPolicyLocation() to be safe, it's declared just
below.

[Devlin, 2014-05-13 17:21:30]

On 2014/05/13 17:06:44, kalman wrote:
> On 2014/05/13 17:03:03, D Cronin wrote:
> >
>
https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
> > File extensions/common/permissions/permissions_data.cc (right):
> > 
> >
>
https://codereview.chromium.org/288453002/diff/1/extensions/common/permission...
> > extensions/common/permissions/permissions_data.cc:572: extension->location()
> !=
> > Manifest::EXTERNAL_COMPONENT &&
> > On 2014/05/13 00:00:16, kalman wrote:
> > > At a higher level this:
> > > - shouldn't include extensions that don't appear in chrome://extensions
(use
> > > ShouldDisplayInExtensionSettings)
> > > - shouldn't include policy obviously. 
> > 
> > Are there any policy ones, other than EXTERNAL_POLICY[_DOWNLOAD]?
> 
> Nope:
>
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...
> 
> But you could check Manifest::IsPolicyLocation() to be safe, it's declared
just
> below.

I must be blind... I swore I looked for that.  Okay, cleaner checks in place.

[Devlin, 2014-05-13 17:31:34]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-05-13 17:32:39]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/288453002/...

[commit-bot: I haz the power, 2014-05-13 20:00:23]

Change committed as 270181