RELAND: Image Capture: wire setPhotoOptions() for Win

RELAND: Image Capture: wire setPhotoOptions() for Win

Original CL got reverted due to constructions like:
if (bla) {
  HRESULT hr = foo();
  DLOG_IF_FAILED_WITH_HRESULT("bla", hr)
}

which caused an error in the waterfall bots (not in the CQ)
because of |hr| going unused.  This CL corrects this.

Original CL description ------------------------------------------------
This CL wires the photo capabilities setPhotoOptions() method:

- |camera_control_| and |video_control_| are made member
 variables, which forces trivial updates to the lambdas.

- most of the controls are straightforward except white
balance and exposure: those have a 'manual' and 'auto'
that enable the use of |color_temperature| and
|exposure_compensation|, resp.  Since either of them can
be configured in subsequent setPhotoOptions() cycles, we need
member flags to keep the manual/auto state.

BUG=657128
Review-Url: https://codereview.chromium.org/2873143002
Cr-Commit-Position: refs/heads/master@{#471554}
Committed: https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a00616c0b22dd

patch from issue 2873143002 at patchset 80001 (http://crrev.com/2873143002#ps80001)

TBR=robliao@chromium.org

Review-Url: https://codereview.chromium.org/2884513002
Cr-Commit-Position: refs/heads/master@{#471623}
Committed: https://chromium.googlesource.com/chromium/src/+/7bda7a4b1a6b2866538f903e06824500894d7d61

[mcasas, 2017-05-14 03:37:31]

Description was changed from

==========
Image Capture: wire setPhotoOptions() for Win


Original CL description ------------------------------------------------
This CL wires the photo capabilities setPhotoOptions() method:

- |camera_control_| and |video_control_| are made member
 variables, which forces trivial updates to the lambdas.

- most of the controls are straightforward except white
balance and exposure: those have a 'manual' and 'auto'
that enable the use of |color_temperature| and
|exposure_compensation|, resp.  Since either of them can
be configured in subsequent setPhotoOptions() cycles, we need
member flags to keep the manual/auto state.

BUG=657128

Review-Url: https://codereview.chromium.org/2873143002
Cr-Commit-Position: refs/heads/master@{#471554}
Committed:
https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a...

patch from issue 2873143002 at patchset 80001
(http://crrev.com/2873143002#ps80001)
==========

to

==========
RELAND: Image Capture: wire setPhotoOptions() for Win

Original CL got reverted due to constructions like:
if (bla) {
  HRESULT hr = foo();
  DLOG_IF_FAILED_WITH_HRESULT("bla", hr)
}

which caused an error in the waterfall bots (not in the CQ)
because of |hr| going unused.  This CL corrects this.

Original CL description ------------------------------------------------
This CL wires the photo capabilities setPhotoOptions() method:

- |camera_control_| and |video_control_| are made member
 variables, which forces trivial updates to the lambdas.

- most of the controls are straightforward except white
balance and exposure: those have a 'manual' and 'auto'
that enable the use of |color_temperature| and
|exposure_compensation|, resp.  Since either of them can
be configured in subsequent setPhotoOptions() cycles, we need
member flags to keep the manual/auto state.

BUG=657128

Review-Url: https://codereview.chromium.org/2873143002
Cr-Commit-Position: refs/heads/master@{#471554}
Committed:
https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a...

patch from issue 2873143002 at patchset 80001
(http://crrev.com/2873143002#ps80001)
==========

[mcasas, 2017-05-14 05:04:16]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-14 05:04:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-14 06:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-14 06:30:20]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-05-14 07:03:50]

Description was changed from

==========
RELAND: Image Capture: wire setPhotoOptions() for Win

Original CL got reverted due to constructions like:
if (bla) {
  HRESULT hr = foo();
  DLOG_IF_FAILED_WITH_HRESULT("bla", hr)
}

which caused an error in the waterfall bots (not in the CQ)
because of |hr| going unused.  This CL corrects this.

Original CL description ------------------------------------------------
This CL wires the photo capabilities setPhotoOptions() method:

- |camera_control_| and |video_control_| are made member
 variables, which forces trivial updates to the lambdas.

- most of the controls are straightforward except white
balance and exposure: those have a 'manual' and 'auto'
that enable the use of |color_temperature| and
|exposure_compensation|, resp.  Since either of them can
be configured in subsequent setPhotoOptions() cycles, we need
member flags to keep the manual/auto state.

BUG=657128

Review-Url: https://codereview.chromium.org/2873143002
Cr-Commit-Position: refs/heads/master@{#471554}
Committed:
https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a...

patch from issue 2873143002 at patchset 80001
(http://crrev.com/2873143002#ps80001)
==========

to

==========
RELAND: Image Capture: wire setPhotoOptions() for Win

Original CL got reverted due to constructions like:
if (bla) {
  HRESULT hr = foo();
  DLOG_IF_FAILED_WITH_HRESULT("bla", hr)
}

which caused an error in the waterfall bots (not in the CQ)
because of |hr| going unused.  This CL corrects this.

Original CL description ------------------------------------------------
This CL wires the photo capabilities setPhotoOptions() method:

- |camera_control_| and |video_control_| are made member
 variables, which forces trivial updates to the lambdas.

- most of the controls are straightforward except white
balance and exposure: those have a 'manual' and 'auto'
that enable the use of |color_temperature| and
|exposure_compensation|, resp.  Since either of them can
be configured in subsequent setPhotoOptions() cycles, we need
member flags to keep the manual/auto state.

BUG=657128

Review-Url: https://codereview.chromium.org/2873143002
Cr-Commit-Position: refs/heads/master@{#471554}
Committed:
https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a...

patch from issue 2873143002 at patchset 80001
(http://crrev.com/2873143002#ps80001)

TBR=robliao@chromium.org
==========

[mcasas, 2017-05-14 07:04:03]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-14 07:04:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-14 08:23:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494745443488690,
"parent_rev": "0d4efb2fa21de85b0b5637e151447a4e23c81b06", "commit_rev":
"6ad23289a99559a87b0e9653979ca6731877c9da"}

[commit-bot: I haz the power, 2017-05-14 08:24:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494745443488690,
"parent_rev": "80429170bb3de6b4639f42fc630a2d1f8b8a7117", "commit_rev":
"7bda7a4b1a6b2866538f903e06824500894d7d61"}

[commit-bot: I haz the power, 2017-05-14 08:24:11]

Description was changed from

==========
RELAND: Image Capture: wire setPhotoOptions() for Win

Original CL got reverted due to constructions like:
if (bla) {
  HRESULT hr = foo();
  DLOG_IF_FAILED_WITH_HRESULT("bla", hr)
}

which caused an error in the waterfall bots (not in the CQ)
because of |hr| going unused.  This CL corrects this.

Original CL description ------------------------------------------------
This CL wires the photo capabilities setPhotoOptions() method:

- |camera_control_| and |video_control_| are made member
 variables, which forces trivial updates to the lambdas.

- most of the controls are straightforward except white
balance and exposure: those have a 'manual' and 'auto'
that enable the use of |color_temperature| and
|exposure_compensation|, resp.  Since either of them can
be configured in subsequent setPhotoOptions() cycles, we need
member flags to keep the manual/auto state.

BUG=657128

Review-Url: https://codereview.chromium.org/2873143002
Cr-Commit-Position: refs/heads/master@{#471554}
Committed:
https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a...

patch from issue 2873143002 at patchset 80001
(http://crrev.com/2873143002#ps80001)

TBR=robliao@chromium.org
==========

to

==========
RELAND: Image Capture: wire setPhotoOptions() for Win

Original CL got reverted due to constructions like:
if (bla) {
  HRESULT hr = foo();
  DLOG_IF_FAILED_WITH_HRESULT("bla", hr)
}

which caused an error in the waterfall bots (not in the CQ)
because of |hr| going unused.  This CL corrects this.

Original CL description ------------------------------------------------
This CL wires the photo capabilities setPhotoOptions() method:

- |camera_control_| and |video_control_| are made member
 variables, which forces trivial updates to the lambdas.

- most of the controls are straightforward except white
balance and exposure: those have a 'manual' and 'auto'
that enable the use of |color_temperature| and
|exposure_compensation|, resp.  Since either of them can
be configured in subsequent setPhotoOptions() cycles, we need
member flags to keep the manual/auto state.

BUG=657128

Review-Url: https://codereview.chromium.org/2873143002
Cr-Commit-Position: refs/heads/master@{#471554}
Committed:
https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a...

patch from issue 2873143002 at patchset 80001
(http://crrev.com/2873143002#ps80001)

TBR=robliao@chromium.org

Review-Url: https://codereview.chromium.org/2884513002
Cr-Commit-Position: refs/heads/master@{#471623}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bda7a4b1a6b2866538f903e0682...
==========

[commit-bot: I haz the power, 2017-05-14 08:24:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7bda7a4b1a6b2866538f903e0682...