Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288443006: Oilpan: Prepare moving ShadowRoot to oilpan. (Closed)

Created:
6 years, 7 months ago by keishi
Modified:
6 years, 7 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Visibility:
Public.

Description

Oilpan: Prepare moving ShadowRoot to oilpan. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174344

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M Source/core/dom/ContainerNodeAlgorithms.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScopeTest.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/TextIteratorTest.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
keishi
6 years, 7 months ago (2014-05-14 11:38:44 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-14 11:41:54 UTC) #2
keishi
6 years, 7 months ago (2014-05-14 12:00:31 UTC) #3
Mads Ager (chromium)
lgtm2
6 years, 7 months ago (2014-05-15 09:00:03 UTC) #4
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 7 months ago (2014-05-20 03:43:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/288443006/20001
6 years, 7 months ago (2014-05-20 03:44:08 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 04:42:52 UTC) #7
tkent
lgtm
6 years, 7 months ago (2014-05-20 04:48:23 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 04:56:42 UTC) #9
Message was sent while issue was closed. 
Change committed as 174344

Powered by Google App Engine
This is Rietveld 408576698