Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/android/overscroll_glow.cc

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)
Patch Set: Fix nits and rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/android/overscroll_glow.h ('K') | « ui/android/overscroll_glow.h ('k') | ui/android/overscroll_refresh.h » ('j') | ui/android/overscroll_refresh.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/overscroll_glow.cc
diff --git a/ui/android/overscroll_glow.cc b/ui/android/overscroll_glow.cc
index 7f3c43da3068c44a15e0fbb1e8a8f816619d8d16..b29b645d213867a758629cc21ed2b05d2b53907e 100644
--- a/ui/android/overscroll_glow.cc
+++ b/ui/android/overscroll_glow.cc
@@ -38,9 +38,7 @@ OverscrollGlow::OverscrollGlow(OverscrollGlowClient* client)
edge_offsets_(),
initialized_(false),
allow_horizontal_overscroll_(true),
- allow_vertical_overscroll_(true) {
- DCHECK(client);
boliu 2017/08/23 19:17:02 ditto fix test rather than relax production checks
sunyunjia 2017/08/23 23:47:05 Done.
-}
+ allow_vertical_overscroll_(true) {}
OverscrollGlow::~OverscrollGlow() {
Detach();
@@ -194,6 +192,7 @@ bool OverscrollGlow::InitializeIfNecessary() {
return true;
DCHECK(!root_layer_.get());
+ DCHECK(client_);
root_layer_ = cc::Layer::Create();
for (size_t i = 0; i < EDGE_COUNT; ++i) {
edge_effects_[i] = client_->CreateEdgeEffect();
« ui/android/overscroll_glow.h ('K') | « ui/android/overscroll_glow.h ('k') | ui/android/overscroll_refresh.h » ('j') | ui/android/overscroll_refresh.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698