Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: ui/android/overscroll_glow.h

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)
Patch Set: Update the test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/overscroll_glow.h
diff --git a/ui/android/overscroll_glow.h b/ui/android/overscroll_glow.h
index 8253de04575409bc89361f322adc9399fa1c124f..caaf5ad4110dc6ac272f818eb1adff4ed00ed479 100644
--- a/ui/android/overscroll_glow.h
+++ b/ui/android/overscroll_glow.h
@@ -40,6 +40,8 @@ class UI_ANDROID_EXPORT OverscrollGlow {
// The effect is enabled by default, but will remain dormant until the first
// overscroll event.
explicit OverscrollGlow(OverscrollGlowClient* client);
+ // This constructor is for test only.
majidvp 2017/07/12 21:04:21 Why is this needed? Can't we just use the above co
sunyunjia 2017/07/19 20:44:12 Done.
+ OverscrollGlow();
~OverscrollGlow();
// Called when the root content layer overscrolls.
@@ -47,11 +49,11 @@ class UI_ANDROID_EXPORT OverscrollGlow {
// |velocity| is in device pixels / second.
// |overscroll_location| is the coordinate of the causal overscrolling event.
// Returns true if the effect still needs animation ticks.
- bool OnOverscrolled(base::TimeTicks current_time,
- const gfx::Vector2dF& accumulated_overscroll,
- gfx::Vector2dF overscroll_delta,
- gfx::Vector2dF velocity,
- const gfx::Vector2dF& overscroll_location);
+ virtual bool OnOverscrolled(base::TimeTicks current_time,
+ const gfx::Vector2dF& accumulated_overscroll,
+ gfx::Vector2dF overscroll_delta,
+ gfx::Vector2dF velocity,
+ const gfx::Vector2dF& overscroll_location);
// Returns true if the effect still needs animation ticks, with effect layers
// attached to |parent_layer| if necessary.

Powered by Google App Engine
This is Rietveld 408576698