ui/events/blink/did_overscroll_params.h - Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/blink/did_overscroll_params.h

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)

Patch Set: Added missing files Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/public/platform/WebScrollBoundaryBehavior.h ('K') | « ui/events/blink/DEPS ('k') | ui/events/blink/did_overscroll_params.cc » ('j') | ui/events/blink/did_overscroll_params.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_EVENTS_BLINK_DID_OVERSCROLL_PARAMS_H_	5 #ifndef UI_EVENTS_BLINK_DID_OVERSCROLL_PARAMS_H_

6 #define UI_EVENTS_BLINK_DID_OVERSCROLL_PARAMS_H_	6 #define UI_EVENTS_BLINK_DID_OVERSCROLL_PARAMS_H_

7	7

	8 #include "cc/input/scroll_boundary_behavior.h"

8 #include "ui/gfx/geometry/point_f.h"	9 #include "ui/gfx/geometry/point_f.h"

9 #include "ui/gfx/geometry/vector2d_f.h"	10 #include "ui/gfx/geometry/vector2d_f.h"

10	11

11 namespace ui {	12 namespace ui {

12	13

13 struct DidOverscrollParams {	14 struct DidOverscrollParams {

14 DidOverscrollParams();	15 DidOverscrollParams();

15 ~DidOverscrollParams();	16 ~DidOverscrollParams();

	17 void ClearX();

	18 void ClearY();

	19

16 gfx::Vector2dF accumulated_overscroll;	20 gfx::Vector2dF accumulated_overscroll;

17 gfx::Vector2dF latest_overscroll_delta;	21 gfx::Vector2dF latest_overscroll_delta;

18 gfx::Vector2dF current_fling_velocity;	22 gfx::Vector2dF current_fling_velocity;

19 gfx::PointF causal_event_viewport_point;	23 gfx::PointF causal_event_viewport_point;

	24 cc::ScrollBoundaryBehavior scroll_boundary_behavior;
	majidvp 2017/05/18 15:26:10 I wonder if there is a preference to use the WebSc I wonder if there is a preference to use the WebScrollBoundaryBehavior instead? Perhaps best to consult one of the OWNERs e.g., @dtapuska to see if there is a guideline. sunyunjia 2017/05/19 20:14:24 Dave said that the cc value is fine in this struct Show quoted text On 2017/05/18 15:26:10, majidvp wrote: > I wonder if there is a preference to use the WebScrollBoundaryBehavior instead? > Perhaps best to consult > one of the OWNERs e.g., @dtapuska to see if there is a guideline. > Dave said that the cc value is fine in this struct
20 };	25 };

21	26

22 } // namespace ui	27 } // namespace ui

23	28

24 #endif // UI_EVENTS_BLINK_DID_OVERSCROLL_PARAMS_H_	29 #endif // UI_EVENTS_BLINK_DID_OVERSCROLL_PARAMS_H_

OLD	NEW