third_party/WebKit/public/platform/WebScrollBoundaryBehavior.h - Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/WebScrollBoundaryBehavior.h

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)

Patch Set: Added missing files Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebScrollBoundaryBehavior_h

	6 #define WebScrollBoundaryBehavior_h

	7

	8 #include "cc/input/scroll_boundary_behavior.h"

	9

	10 namespace blink {

	11

	12 struct WebScrollBoundaryBehavior : public cc::ScrollBoundaryBehavior {

	13 using ScrollBoundaryBehavior::ScrollBoundaryBehavior;
	majidvp 2017/05/18 15:26:10 I am confused by this using statement. First shou I am confused by this using statement. First should this be cc::ScrollBoundaryBehavior, Second is it trying to bring in the enum into the namespace? so ScrollBoundaryBehaviorType? sunyunjia 2017/05/19 20:14:23 That was a way I found on stackoverflow to inherit Show quoted text On 2017/05/18 15:26:10, majidvp wrote: > I am confused by this using statement. > First should this be cc::ScrollBoundaryBehavior, > Second is it trying to bring in the enum into the namespace? so > ScrollBoundaryBehaviorType? That was a way I found on stackoverflow to inherit the constructor, which is really confusing. I've changed it to a normal approach.
	14 };

	15

	16 } // namespace blink

	17

	18 #endif

OLD	NEW