Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2884413002: Ensure (de)compressor is always closed. (Closed)

Created:
3 years, 7 months ago by ryanmartens
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Ensure (de)compressor is always closed. Minor cleanup of a few missing calls to Close() on decompressor and compressor instances. R=maruel@chromium.org, mcgreevy@chromium.org, tandrii@chromium.org BUG= Review-Url: https://codereview.chromium.org/2884413002 Committed: https://github.com/luci/luci-go/commit/cc622525b7650903d662f7bb4071c8d8132df6f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M common/isolatedclient/isolatedclient.go View 1 chunk +1 line, -0 lines 0 comments Download
M common/isolatedclient/isolatedfake/isolatedfake.go View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ryanmartens
3 years, 7 months ago (2017-05-16 19:09:33 UTC) #1
ryanmartens
On 2017/05/16 19:09:33, ryanmartens wrote: Just a friendly ping on this one.
3 years, 7 months ago (2017-05-18 13:35:18 UTC) #2
tandrii_google
lgtm
3 years, 7 months ago (2017-05-18 13:44:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884413002/1
3 years, 7 months ago (2017-05-18 13:50:32 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 13:56:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/cc622525b7650903d662f7bb4071c8d8132df6f4

Powered by Google App Engine
This is Rietveld 408576698