Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2884403002:
DevTools: fix exception on heap snapshot error reporting. (Closed)
|
Created:
3 years, 7 months ago by alph Modified:
3 years, 7 months ago Reviewers:
caseq CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: fix exception on heap snapshot error reporting.
The debug log may access node.name() property during initialize method.
Make sure the cache is allocated.
BUG=691935
Review-Url: https://codereview.chromium.org/2884403002
Cr-Commit-Position: refs/heads/master@{#472647}
Committed: https://chromium.googlesource.com/chromium/src/+/dd5a66b4a00a250bcf9476bd373544c4d75bd81c
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
alph@chromium.org changed reviewers: + caseq@chromium.org
The CQ bit was checked by caseq@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495060035919920, "parent_rev":
"25c5c824f966d42bf627fd53adb3ef9da3b0cb61", "commit_rev":
"dd5a66b4a00a250bcf9476bd373544c4d75bd81c"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: fix exception on heap snapshot error reporting. The debug log may access node.name() property during initialize method. Make sure the cache is allocated. BUG=691935 ========== to ========== DevTools: fix exception on heap snapshot error reporting. The debug log may access node.name() property during initialize method. Make sure the cache is allocated. BUG=691935 Review-Url: https://codereview.chromium.org/2884403002 Cr-Commit-Position: refs/heads/master@{#472647} Committed: https://chromium.googlesource.com/chromium/src/+/dd5a66b4a00a250bcf9476bd3735... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dd5a66b4a00a250bcf9476bd3735... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
