Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2884383006: [Telemetry] Split Oopif page_cycler_v2 benchmarks into their own file. (Closed)

Created:
3 years, 7 months ago by rnephew (Reviews Here)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, nasko
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Split Oopif page_cycler_v2 benchmarks into their own file. We are currently working on removing the page_cycler_v2 benchmarks, replacing them with the new loading.desktop benchmark. The Oopif page cycler v2 benchmarks are not yet ready for this, so we have to split them into their own benchmarks seperate from page_cycler_v2. The name shall rename the same (including the page_cycler_v2) in order to keep the data in the same place on the dashboard. Eventually Oopif benchmarks will be migrated to the new loading benchmark harness as well. BUG=713346 Review-Url: https://codereview.chromium.org/2884383006 Cr-Commit-Position: refs/heads/master@{#473067} Committed: https://chromium.googlesource.com/chromium/src/+/5cf77c9e72082bfc4b0a7a9e1481b20569eacac5

Patch Set 1 #

Total comments: 1

Patch Set 2 : add a todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -33 lines) Patch
A tools/perf/benchmarks/oopif.py View 1 1 chunk +91 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/page_cycler_v2.py View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
rnephew (Reviews Here)
Nasko@, from your perspective this CL should be a noop. Everything should go to the ...
3 years, 7 months ago (2017-05-18 23:22:48 UTC) #2
nednguyen
lgtm
3 years, 7 months ago (2017-05-18 23:27:28 UTC) #4
nednguyen
https://codereview.chromium.org/2884383006/diff/1/tools/perf/benchmarks/oopif.py File tools/perf/benchmarks/oopif.py (right): https://codereview.chromium.org/2884383006/diff/1/tools/perf/benchmarks/oopif.py#newcode19 tools/perf/benchmarks/oopif.py:19: def AugmentOptionsForLoadingMetrics(tbm_options): if this is moved to loading.py, can ...
3 years, 7 months ago (2017-05-18 23:28:21 UTC) #5
rnephew (Reviews Here)
On 2017/05/18 23:27:28, nednguyen wrote: > lgtm I added a simple TODO telling me to ...
3 years, 7 months ago (2017-05-18 23:28:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884383006/20001
3 years, 7 months ago (2017-05-18 23:30:49 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 03:48:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5cf77c9e72082bfc4b0a7a9e1481...

Powered by Google App Engine
This is Rietveld 408576698