Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(38)

Issue 2884383003: Replace DCHECK with conditional and error. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by DaleCurtis
Modified:
5 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DCHECK with conditional and error. libfuzzer always finds a way to trigger these; thanks! This replaces a discard helper DCHECK with a conditional failure. BUG=717775 TEST=fuzzer doesn't check fail anymore. Review-Url: https://codereview.chromium.org/2884383003 Cr-Commit-Position: refs/heads/master@{#472885} Committed: https://chromium.googlesource.com/chromium/src/+/6548bcbdb7254440df8aab0fa8d9bc1dc179364e

Patch Set 1 #

Messages

Total messages: 12 (6 generated)
DaleCurtis
5 months ago (2017-05-17 01:03:58 UTC) #2
chcunningham
lgtm
5 months ago (2017-05-17 23:25:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884383003/1
5 months ago (2017-05-18 00:14:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/430172)
5 months ago (2017-05-18 06:25:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884383003/1
5 months ago (2017-05-18 17:11:44 UTC) #9
commit-bot: I haz the power
5 months ago (2017-05-18 18:42:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6548bcbdb7254440df8aab0fa8d9...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa