Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2884363003: Reland - Notify paint for each frame (Closed)

Created:
3 years, 7 months ago by Zhen Wang
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, fmalita+watch_chromium.org, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, zoltan1, speed-metrics-reviews_chromium.org, blink-reviews-layout_chromium.org, csharrison+watch_chromium.org, pdr+graphicswatchlist_chromium.org, Stephen Chennney, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, loading-reviews+metrics_chromium.org, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland - Notify paint for each frame This CL relands https://crrev.com/2872793002/ after Bryan fixes https://crbug.com/722860. Currently main frame reports paint timing and subframes report paint timing via main frame. The desired behavior is that each frame reports its own paint timing. BUG=705315 TBR=bmcquade@chromium.org,chrishtr@chromium.org,wangxianzhu@chromium.org,panicker@chromium.org, CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2884363003 Cr-Commit-Position: refs/heads/master@{#472457} Committed: https://chromium.googlesource.com/chromium/src/+/2701c48359353889f90c30309ff523273890cca7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -107 lines) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 6 chunks +11 lines, -55 lines 0 comments Download
M chrome/test/data/page_load_metrics/empty_iframe.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/page_load_metrics/iframe.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/page_load_metrics/iframes.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/data/page_load_metrics/main_frame_with_iframe.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/FramePaintTiming.h View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 5 chunks +31 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 3 chunks +33 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884363003/1
3 years, 7 months ago (2017-05-16 20:59:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/295459) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-16 22:54:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884363003/1
3 years, 7 months ago (2017-05-17 15:10:21 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 15:17:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2701c48359353889f90c30309ff5...

Powered by Google App Engine
This is Rietveld 408576698