fuchsia: base_unittests (mostly) compiling

build/config/compiler/BUILD.gn

Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 7f57d912d6f1ec60650af9ce04dc3bf61fc37683..e6ad948e8c4c71bda39639ece32a54e6fb3fb56f 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1091,7 +1091,7 @@ config("default_warnings") {
       "-Wno-inconsistent-missing-override",
     ]
 
-    if (is_linux && target_cpu == "x86") {
+    if ((is_linux && target_cpu == "x86") || is_fuchsia) {

[Nico, 2017/05/17 15:52:54]

1.) If this happens only in ICU, we should suppress it only there, not globally.
2.) Why does this happen for ICU only for fuchsia?

[scottmg, 2017/05/17 16:52:51]

Hmm, #2 is a good question... here's the command lines
https://gist.github.com/sgraham/c806b636d0d58df4f534d100960df103

Digging into the flags a bit (%s/ /^M, %!sort, %!uniq, diff) I get this:

[scottmg:~]$ diff linux.txt fuchsia.txt
2,3c2,3
< --sysroot=../../build/linux/debian_jessie_amd64-sysroot
< -B../../third_party/binutils/Linux_x64/Release/bin
---
12a13
15a17
18,24d19
< -DUSE_AURA=1
< -DUSE_CAIRO=1
< -DUSE_GLIB=1
< -DUSE_NSS_CERTS=1
< -DUSE_PANGO=1
< -DUSE_UDEV
< -DUSE_X11=1
52d46
< -Wno-deprecated
84d77
< -load
90,91c83
< -pthread
< -std=gnu++11
---
94d85
< ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
96d86
< check-ipc

I was hoping it was -std=gnu++11 vs c++11 but it's actually that I didn't turn
on all of the -Wno-deprecated
https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=5f7ac...
"for hash_map".

       cflags += [
         # TODO(thakis): Remove from 32-bit Linux eventually, https://707084
         "-Wno-deprecated-register",