Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/trace_event/malloc_dump_provider.cc

Issue 2884353004: fuchsia: base_unittests (mostly) compiling (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/test/launcher/test_launcher.cc ('K') | « base/threading/platform_thread_posix.cc ('k') | base/trace_event/memory_allocator_dump_unittest.cc » ('j') | build/config/compiler/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/malloc_dump_provider.cc
diff --git a/base/trace_event/malloc_dump_provider.cc b/base/trace_event/malloc_dump_provider.cc
index 047f2c336d5c6295086316b12f883811ab9f2b0c..cb13383ae99fc0690252f7b61cfc2b0954f9f084 100644
--- a/base/trace_event/malloc_dump_provider.cc
+++ b/base/trace_event/malloc_dump_provider.cc
@@ -242,6 +242,8 @@ bool MallocDumpProvider::OnMemoryDump(const MemoryDumpArgs& args,
resident_size = main_heap_info.committed_size;
allocated_objects_size = main_heap_info.allocated_size;
allocated_objects_count = main_heap_info.block_count;
+#elif defined(OS_FUCHSIA)
+// TODO(scottmg): Port, see https://crbug.com/706592.
Nico 2017/05/17 15:52:54 Please use TODO(fuchsia) for all these, for greppa
scottmg 2017/05/17 16:52:51 Done.
#else
struct mallinfo info = mallinfo();
DCHECK_GE(info.arena + info.hblkhd, info.uordblks);
« base/test/launcher/test_launcher.cc ('K') | « base/threading/platform_thread_posix.cc ('k') | base/trace_event/memory_allocator_dump_unittest.cc » ('j') | build/config/compiler/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698