Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2884343005: Revert of Separate WebView's locale paks from Chrome's locale paks (Closed)

Created:
3 years, 7 months ago by F
Modified:
3 years, 7 months ago
Reviewers:
michaelbai, Nico, agrieve, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Separate WebView's locale paks from Chrome's locale paks (patchset #3 id:60001 of https://codereview.chromium.org/2890813002/ ) Reason for revert: creates different paks for 32bit & 64bit: see crbug.com/724277 Original issue's description: > Separate WebView's locale paks from Chrome's locale paks > > In order to reduce APK size, this CL separates WebView's locale paks > from Chrome's locale paks, and compresses locale paks for all flavors > of Chrome. > > Previously, Chrome and Chrome modern have their locale paks compressed, > while their contemporary WebView is shipped as a standalone APK and has > its own locale paks stored uncompressed. For Monochrome, WebView and > Chrome share uncompressed locale paks. As a result, Monochrome locale > paks take up lots of disk space unnecessarily. > > This CL changes WebView locale pak location for all WebViews, and > compresses Chrome's locale paks in Monochrome. As a result, Monochrome > now contains uncompressed WebView locale paks and compressed Chrome > locale paks. Other resources are not affected. This greatly reduces > locale paks' footprints on disk. Monochrome.apk shrinks by 2.6MB. > > A side effect for this CL is that Monochrome no longer supports several > locales that have been unsupported by Chrome and Chrome modern but > supported by WebViews. > > See crbug.com/687797 for more details. > > BUG=687797 > > Review-Url: https://codereview.chromium.org/2890813002 > Cr-Commit-Position: refs/heads/master@{#472801} > Committed: https://chromium.googlesource.com/chromium/src/+/b19aa78ac188365efe6b54c3889d67e9225b10d2 TBR=agrieve@chromium.org,michaelbai@chromium.org,torne@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687797, 724277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -37 lines) Patch
M android_webview/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/android/BUILD.gn View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_paks.gni View 3 chunks +23 lines, -25 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ResourceBundle.java View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
F
Created Revert of Separate WebView's locale paks from Chrome's locale paks
3 years, 7 months ago (2017-05-19 00:24:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884343005/1
3 years, 7 months ago (2017-05-19 00:26:53 UTC) #4
michaelbai
I believe it has been reverted.
3 years, 7 months ago (2017-05-19 00:27:07 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 00:28:08 UTC) #7
Failed to apply patch for android_webview/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: android_webview/BUILD.gn:112
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: android_webview/BUILD.gn: patch does not apply

Patch:       android_webview/BUILD.gn
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index
6b2cfdee2a9e5a554e8267c4c740ef199c7c8d44..cb2c49d3e351916b3a37dc917463752e5e4674a6
100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -112,11 +112,9 @@
 
 android_assets("locale_pak_assets") {
   disable_compression = true
-  renaming_sources = []
-  renaming_destinations = []
+  sources = []
   foreach(_locale, locales) {
-    renaming_sources += [ "$root_out_dir/android_webview/locales/$_locale.pak"
]
-    renaming_destinations += [ "stored-locales/$_locale.pak" ]
+    sources += [ "$root_out_dir/android_webview/locales/$_locale.pak" ]
   }
   deps = [
     ":repack_locales",

Powered by Google App Engine
This is Rietveld 408576698