Leave ChromeOS system menu open when toggling nightlight.

Leave ChromeOS system menu open when toggling nightlight.

BUG=721439
Review-Url: https://codereview.chromium.org/2884323002
Cr-Commit-Position: refs/heads/master@{#473601}
Committed: https://chromium.googlesource.com/chromium/src/+/fc7414e6b883f12100d0271afbf33a5bf46ee17a

[Evan Stade, 2017-05-16 21:39:23]

Description was changed from

==========
wip nightlight

BUG=
==========

to

==========
Leave ChromeOS system menu open when toggling nightlight.

BUG=721439
==========

[Evan Stade, 2017-05-16 21:39:23]

estade@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Evan Stade, 2017-05-16 21:40:29]

https://codereview.chromium.org/2884323002/diff/20001/ash/system/tiles/tiles_...
File ash/system/tiles/tiles_default_view.cc (left):

https://codereview.chromium.org/2884323002/diff/20001/ash/system/tiles/tiles_...
ash/system/tiles/tiles_default_view.cc:140:
owner_->system_tray()->CloseSystemBubble();
it's OK to just remove this because the other 4 buttons launch dialogs that
cause the menu to close anyway.

[Evan Stade, 2017-05-16 21:40:34]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 21:42:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-05-16 21:44:29]

lgtm

[Evan Stade, 2017-05-16 21:45:23]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2017-05-16 21:45:28]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-05-16 21:46:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:22:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-05-17 22:11:13]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-17 22:11:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2884323002/#ps40001
(title: "rebase")

[Evan Stade, 2017-05-18 18:41:59]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-18 18:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2884323002/#ps60001
(title: "revert accidental change")

[commit-bot: I haz the power, 2017-05-18 18:43:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:49:00]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2017-05-19 16:03:49]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-19 16:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2884323002/#ps80001
(title: "fix self-conflict")

[commit-bot: I haz the power, 2017-05-19 16:04:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 16:19:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-05-19 16:22:56]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-19 16:22:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2884323002/#ps100001
(title: "adjust for fn rename")

[commit-bot: I haz the power, 2017-05-19 16:23:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 16:39:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-05-22 16:27:15]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-22 16:27:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2884323002/#ps120001
(title: "fix messed up include")

[commit-bot: I haz the power, 2017-05-22 16:27:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 16:58:13]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495470435026260,
"parent_rev": "083e943d8ea4952a225355d1a40d945aa1e1c3f6", "commit_rev":
"fc7414e6b883f12100d0271afbf33a5bf46ee17a"}

[commit-bot: I haz the power, 2017-05-22 16:58:25]

Description was changed from

==========
Leave ChromeOS system menu open when toggling nightlight.

BUG=721439
==========

to

==========
Leave ChromeOS system menu open when toggling nightlight.

BUG=721439

Review-Url: https://codereview.chromium.org/2884323002
Cr-Commit-Position: refs/heads/master@{#473601}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc7414e6b883f12100d0271afbf3...
==========

[commit-bot: I haz the power, 2017-05-22 16:58:26]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/fc7414e6b883f12100d0271afbf3...