third_party/WebKit/Source/core/dom/NodeFilter.idl - Issue 2884263002: NodeFilter#acceptNode argument node should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NodeFilter.idl

Issue 2884263002: NodeFilter#acceptNode argument node should not be optional (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/NodeFilter.idl

diff --git a/third_party/WebKit/Source/core/dom/NodeFilter.idl b/third_party/WebKit/Source/core/dom/NodeFilter.idl

index b4d6ccb6e3aaefd420e52ba0cf40ab3839c57930..875ec6e19d54e506f66f805e9549df85d8e96de3 100644

--- a/third_party/WebKit/Source/core/dom/NodeFilter.idl

+++ b/third_party/WebKit/Source/core/dom/NodeFilter.idl

@@ -47,5 +47,5 @@

// V8NodeFilterCondition represents this callback interface in Blink.

// TODO(bashi): Fix crbug.com/630986, and use generated code.

// FIXME: The node argument should not be optional.

suchit.agrawal 2017/05/18 07:06:38 remove FIXME.

- [RaisesException] unsigned short acceptNode([Default=Undefined] optional Node node);

+ [RaisesException] unsigned short acceptNode([Default=Undefined] Node node);

};

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »