Add Data-Saver LayoutTest for Worker and SharedWorker

Add Data-Saver LayoutTest for Worker and SharedWorker

While implementing off-main-thread fetch (crbug.com/443374), I noticed that
there is no tests for Data-Saver for Worker and SharedWorker.
And currently Data-Saver doesn't work with SharedWorker. (crbug.com/722774)

BUG=443374, 722774
Review-Url: https://codereview.chromium.org/2884183002
Cr-Commit-Position: refs/heads/master@{#472075}
Committed: https://chromium.googlesource.com/chromium/src/+/a0f1fee8fc23618dd72f5f0bad1d2e3a8e0c623e

[horo, 2017-05-16 08:27:06]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 08:27:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-05-16 08:28:17]

Description was changed from

==========
Add Data-Saver LayoutTest

While implementing off-main-thread fetch (crbug.com/443374), I noticed that
there is no tests for Data-Saver for Worker and SharedWorker
And currently Data-Saver doesn't work with SharedWorker.

BUG=443374
==========

to

==========
Add Data-Saver LayoutTest for Worker and SharedWorker

While implementing off-main-thread fetch (crbug.com/443374), I noticed that
there is no tests for Data-Saver for Worker and SharedWorker
And currently Data-Saver doesn't work with SharedWorker.

BUG=443374
==========

[horo, 2017-05-16 08:35:32]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2017-05-16 08:35:33]

falken@
Could you please review?

[falken, 2017-05-16 08:45:53]

lgtm

can you file a bug and mention http/tests/fetch/chromium/data-saver.html is
failing because DataSaver doesn't work with SharedWorker?

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html
(right):

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html:11:
methods.map(method => new Request(CHECK_PATH, {method: method}));
METHODS and REQUESTS so it's easier to tell they are global?

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html:44: new
Worker('./resources/data-saver-worker.php?dedicated-disabled')
semi-colon

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html:65: new
Worker('./resources/data-saver-worker.php?dedicated-enabled')
semi-colon

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/resources/data-saver-worker.php
(right):

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/resources/data-saver-worker.php:15:
methods.map(method => new Request(CHECK_PATH, {method: method}));
METHODS and REQUESTS?

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/resources/data-saver-worker.php:32:
self.postMessage(result);
nit: indentation

[commit-bot: I haz the power, 2017-05-16 10:02:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 10:02:24]

Dry run: This issue passed the CQ dry run.

[horo, 2017-05-16 10:15:13]

Description was changed from

==========
Add Data-Saver LayoutTest for Worker and SharedWorker

While implementing off-main-thread fetch (crbug.com/443374), I noticed that
there is no tests for Data-Saver for Worker and SharedWorker
And currently Data-Saver doesn't work with SharedWorker.

BUG=443374
==========

to

==========
Add Data-Saver LayoutTest for Worker and SharedWorker

While implementing off-main-thread fetch (crbug.com/443374), I noticed that
there is no tests for Data-Saver for Worker and SharedWorker.
And currently Data-Saver doesn't work with SharedWorker. (crbug.com/722774)

BUG=443374,722774
==========

[horo, 2017-05-16 10:24:39]

Patchset #2 (id:20001) has been deleted

[horo, 2017-05-16 10:25:22]

> can you file a bug and mention http/tests/fetch/chromium/data-saver.html is
> failing because DataSaver doesn't work with SharedWorker?
Done.

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html
(right):

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html:11:
methods.map(method => new Request(CHECK_PATH, {method: method}));
On 2017/05/16 08:45:52, falken wrote:
> METHODS and REQUESTS so it's easier to tell they are global?

Done.

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html:44: new
Worker('./resources/data-saver-worker.php?dedicated-disabled')
On 2017/05/16 08:45:52, falken wrote:
> semi-colon

Done.

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver.html:65: new
Worker('./resources/data-saver-worker.php?dedicated-enabled')
On 2017/05/16 08:45:52, falken wrote:
> semi-colon

Done.

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/resources/data-saver-worker.php
(right):

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/resources/data-saver-worker.php:15:
methods.map(method => new Request(CHECK_PATH, {method: method}));
On 2017/05/16 08:45:53, falken wrote:
> METHODS and REQUESTS?

Done.

https://codereview.chromium.org/2884183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/chromium/resources/data-saver-worker.php:32:
self.postMessage(result);
On 2017/05/16 08:45:53, falken wrote:
> nit: indentation

Done.

[horo, 2017-05-16 10:26:39]

The CQ bit was checked by horo@chromium.org

[horo, 2017-05-16 10:26:39]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2884183002/#ps40001
(title: "incoporated falken's comment and add expected.txt for
virtual/off-main-thread-fetch")

[commit-bot: I haz the power, 2017-05-16 10:26:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 11:16:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 11:16:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2017-05-16 12:55:46]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2017-05-16 12:56:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 13:18:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494939346275120,
"parent_rev": "e322ad10ac9fa83e35d578ae7a4682047d9b52a4", "commit_rev":
"a0f1fee8fc23618dd72f5f0bad1d2e3a8e0c623e"}

[commit-bot: I haz the power, 2017-05-16 13:18:41]

Description was changed from

==========
Add Data-Saver LayoutTest for Worker and SharedWorker

While implementing off-main-thread fetch (crbug.com/443374), I noticed that
there is no tests for Data-Saver for Worker and SharedWorker.
And currently Data-Saver doesn't work with SharedWorker. (crbug.com/722774)

BUG=443374,722774
==========

to

==========
Add Data-Saver LayoutTest for Worker and SharedWorker

While implementing off-main-thread fetch (crbug.com/443374), I noticed that
there is no tests for Data-Saver for Worker and SharedWorker.
And currently Data-Saver doesn't work with SharedWorker. (crbug.com/722774)

BUG=443374,722774

Review-Url: https://codereview.chromium.org/2884183002
Cr-Commit-Position: refs/heads/master@{#472075}
Committed:
https://chromium.googlesource.com/chromium/src/+/a0f1fee8fc23618dd72f5f0bad1d...
==========

[commit-bot: I haz the power, 2017-05-16 13:18:42]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a0f1fee8fc23618dd72f5f0bad1d...