media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService

media/mojo/services/media_service.cc

Index: media/mojo/services/media_service.cc
diff --git a/media/mojo/services/media_service.cc b/media/mojo/services/media_service.cc
index 25e9834d65a36a8ca230b76154f670966742341e..7fc69d3ef70925e8a8f0ab2949205ae6c77c5cd5 100644
--- a/media/mojo/services/media_service.cc
+++ b/media/mojo/services/media_service.cc
@@ -41,6 +41,7 @@ void MediaService::OnBindInterface(
 }
 
 bool MediaService::OnServiceManagerConnectionLost() {
+  interface_factory_bindings_.CloseAllBindings();

[alokp, 2017/05/16 16:54:44]

Do we need to manually delete InterfaceFactory bindings ot |mojo_media_client_|?
If they are declared in the correct order, the right thing should happen
automatically in the destructor.

[xhwang, 2017/05/16 17:05:33]

That should work, but we need a comment to make sure the declaration order is
correct. With that, I feel clearing everything here is cleaner.

   mojo_media_client_.reset();
   return true;
 }
@@ -57,7 +58,7 @@ void MediaService::CreateInterfaceFactory(
   if (!mojo_media_client_)
     return;
 
-  mojo::MakeStrongBinding(
+  interface_factory_bindings_.AddBinding(
       base::MakeUnique<InterfaceFactoryImpl>(
           std::move(host_interfaces), &media_log_, ref_factory_->CreateRef(),
           mojo_media_client_.get()),