media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService

media/mojo/services/media_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/mojo/services/media_service.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "media/base/media_log.h"
@@ skipping 23 matching lines @@
 
 void MediaService::OnBindInterface(
     const service_manager::BindSourceInfo& source_info,
     const std::string& interface_name,
     mojo::ScopedMessagePipeHandle interface_pipe) {
   registry_.BindInterface(source_info, interface_name,
                           std::move(interface_pipe));
 }
 
 bool MediaService::OnServiceManagerConnectionLost() {
+  interface_factory_bindings_.CloseAllBindings();

[alokp, 2017/05/16 16:54:44]

Do we need to manually delete InterfaceFactory bindings ot |mojo_media_client_|?
If they are declared in the correct order, the right thing should happen
automatically in the destructor.

[xhwang, 2017/05/16 17:05:33]

That should work, but we need a comment to make sure the declaration order is
correct. With that, I feel clearing everything here is cleaner.

   mojo_media_client_.reset();
   return true;
 }
 
 void MediaService::Create(const service_manager::BindSourceInfo& source_info,
                           mojom::MediaServiceRequest request) {
   bindings_.AddBinding(this, std::move(request));
 }
 
 void MediaService::CreateInterfaceFactory(
     mojom::InterfaceFactoryRequest request,
     service_manager::mojom::InterfaceProviderPtr host_interfaces) {
   // Ignore request if service has already stopped.
   if (!mojo_media_client_)
     return;
 
-  mojo::MakeStrongBinding(
+  interface_factory_bindings_.AddBinding(
       base::MakeUnique<InterfaceFactoryImpl>(
           std::move(host_interfaces), &media_log_, ref_factory_->CreateRef(),
           mojo_media_client_.get()),
       std::move(request));
 }
 
 }  // namespace media