Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2884143002: Revert "[Memory-UMA] Implement basic working prototype." (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chrome-grc-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, asvitkine+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[Memory-UMA] Implement basic working prototype." Manual revet due to too long file. Reason for revert: Caused ProcessMemoryMetricsEmitterTest.FetchDuringTrace failure on the Linux ChromiumOS Tests builder. BUG=722673, 703184 TBR=rkaplow@chromium.org,avi@chrmium.org,erikchen@chromium.org,dcheng@chromium.org,primiano@chromium.org This reverts commit 18ea873dd28c6b2f49b529e57c55898f5df1b4d2. Review-Url: https://codereview.chromium.org/2884143002 . Cr-Commit-Position: refs/heads/master@{#471985} Committed: https://chromium.googlesource.com/chromium/src/+/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -462 lines) Patch
M chrome/browser/metrics/process_memory_metrics_emitter.cc View 1 chunk +15 lines, -18 lines 0 comments Download
M chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc View 3 chunks +5 lines, -164 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M services/resource_coordinator/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M services/resource_coordinator/memory/coordinator/coordinator_impl.h View 6 chunks +5 lines, -20 lines 0 comments Download
M services/resource_coordinator/memory/coordinator/coordinator_impl.cc View 10 chunks +21 lines, -37 lines 0 comments Download
M services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc View 1 chunk +1 line, -10 lines 0 comments Download
D services/resource_coordinator/memory/coordinator/process_map.h View 1 chunk +0 lines, -61 lines 0 comments Download
D services/resource_coordinator/memory/coordinator/process_map.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D services/resource_coordinator/memory/coordinator/process_map_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
afakhry
3 years, 7 months ago (2017-05-16 02:23:25 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6a9e77ef378c0c835fc9d3265addb0c0d7bd911b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698