Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2884063003: DevTools: console is missing when debugging Node (Closed)

Created:
3 years, 7 months ago by pfeldman
Modified:
3 years, 7 months ago
Reviewers:
paulirish, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: console is missing when debugging Node BUG=722586 Review-Url: https://codereview.chromium.org/2884063003 Cr-Commit-Position: refs/heads/master@{#472107} Committed: https://chromium.googlesource.com/chromium/src/+/6791009b216d80e5e184cf074ff863c345399000

Patch Set 1 #

Patch Set 2 : same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistry.js View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
pfeldman
3 years, 7 months ago (2017-05-15 22:32:36 UTC) #2
alph
lgtm
3 years, 7 months ago (2017-05-15 22:37:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884063003/20001
3 years, 7 months ago (2017-05-15 22:39:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/427203)
3 years, 7 months ago (2017-05-15 23:14:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884063003/20001
3 years, 7 months ago (2017-05-15 23:34:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455131)
3 years, 7 months ago (2017-05-16 01:56:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884063003/20001
3 years, 7 months ago (2017-05-16 13:43:29 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 15:04:02 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6791009b216d80e5e184cf074ff8...

Powered by Google App Engine
This is Rietveld 408576698