Add FontFaceSource interface and make it available on Document

Add FontFaceSource interface and make it available on Document

Move document.fonts to a mixin instead of partial interface.

Per spec: https://drafts.csswg.org/css-font-loading/#font-face-source

BUG=722511
Review-Url: https://codereview.chromium.org/2884053002
Cr-Commit-Position: refs/heads/master@{#472154}
Committed: https://chromium.googlesource.com/chromium/src/+/32dbbeab5cdae35fb757924d339b2d83bc4ea487

[fserb, 2017-05-15 19:51:32]

The CQ bit was checked by fserb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 19:52:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fserb, 2017-05-15 19:54:46]

fserb@chromium.org changed reviewers:
+ dglazkov@chromium.org, foolip@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:42:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:42:26]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-05-16 12:10:45]

Description was changed from

==========
Add FontFaceSource interface and make it available on Document
Per spec: https://www.w3.org/TR/css-font-loading/#font-face-source

BUG=722511
==========

to

==========
Add FontFaceSource interface and make it available on Document

Per spec: https://drafts.csswg.org/css-font-loading/#font-face-source

BUG=722511
==========

[foolip, 2017-05-16 12:11:27]

I updated the description to point to
https://drafts.csswg.org/css-font-loading/#font-face-source

/TR/ is almost never the most up-to-date version of a spec, with a few
exceptions to make things confusing.

[foolip, 2017-05-16 12:15:27]

Looks like this is IDL refactoring only, turning a partial interface into a
mixin + implements statement. Can you clarify that in the description? Maybe
"Move document.fonts to a mixin instead of partial interface".

lgtm

https://codereview.chromium.org/2884053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/FontFaceSource.idl (right):

https://codereview.chromium.org/2884053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/FontFaceSource.idl:2: * Copyright (C) 2017
Google Inc. All rights reserved.
Use the 3-line header that begins "Copyright 2017 The Chromium Authors."

https://codereview.chromium.org/2884053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/FontFaceSource.idl:5: //
https://dev.w3.org/csswg/css-font-loading/#font-face-source
Link to https://drafts.csswg.org/css-font-loading/#font-face-source

[fserb, 2017-05-16 14:08:12]

Description was changed from

==========
Add FontFaceSource interface and make it available on Document

Per spec: https://drafts.csswg.org/css-font-loading/#font-face-source

BUG=722511
==========

to

==========
Add FontFaceSource interface and make it available on Document

Move document.fonts to a mixin instead of partial interface.

Per spec: https://drafts.csswg.org/css-font-loading/#font-face-source

BUG=722511
==========

[fserb, 2017-05-16 14:14:24]

done. thanks.

https://codereview.chromium.org/2884053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/FontFaceSource.idl (right):

https://codereview.chromium.org/2884053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/FontFaceSource.idl:2: * Copyright (C) 2017
Google Inc. All rights reserved.
On 2017/05/16 at 12:15:27, foolip wrote:
> Use the 3-line header that begins "Copyright 2017 The Chromium Authors."

I thought "cl format" or presubmit would pick this. Done.

https://codereview.chromium.org/2884053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/FontFaceSource.idl:5: //
https://dev.w3.org/csswg/css-font-loading/#font-face-source
On 2017/05/16 at 12:15:27, foolip wrote:
> Link to https://drafts.csswg.org/css-font-loading/#font-face-source

Done.

[fserb, 2017-05-16 14:14:38]

The CQ bit was checked by fserb@chromium.org

[fserb, 2017-05-16 14:14:38]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2884053002/#ps20001
(title: "x")

[commit-bot: I haz the power, 2017-05-16 14:15:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 16:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 16:25:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fserb, 2017-05-16 16:58:53]

The CQ bit was checked by fserb@chromium.org

[commit-bot: I haz the power, 2017-05-16 16:59:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:00:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494953933285850,
"parent_rev": "959d42beb82698415e47bfde4fc791e56aa422ed", "commit_rev":
"32dbbeab5cdae35fb757924d339b2d83bc4ea487"}

[commit-bot: I haz the power, 2017-05-16 18:01:04]

Description was changed from

==========
Add FontFaceSource interface and make it available on Document

Move document.fonts to a mixin instead of partial interface.

Per spec: https://drafts.csswg.org/css-font-loading/#font-face-source

BUG=722511
==========

to

==========
Add FontFaceSource interface and make it available on Document

Move document.fonts to a mixin instead of partial interface.

Per spec: https://drafts.csswg.org/css-font-loading/#font-face-source

BUG=722511

Review-Url: https://codereview.chromium.org/2884053002
Cr-Commit-Position: refs/heads/master@{#472154}
Committed:
https://chromium.googlesource.com/chromium/src/+/32dbbeab5cdae35fb757924d339b...
==========

[commit-bot: I haz the power, 2017-05-16 18:01:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/32dbbeab5cdae35fb757924d339b...