Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2884043002: [ObjC ARC] Converts ios/chrome/browser/net:eg_tests to ARC. (Closed)

Created:
3 years, 7 months ago by baxley
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), net-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/net:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363, 690057 TEST=None Review-Url: https://codereview.chromium.org/2884043002 Cr-Commit-Position: refs/heads/master@{#471949} Committed: https://chromium.googlesource.com/chromium/src/+/680ec74a33fcffefd0b1ed6a39686bc8451d80ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/chrome/browser/net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/net/cookies_egtest.mm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
baxley
3 years, 7 months ago (2017-05-15 18:43:59 UTC) #5
baxley
3 years, 7 months ago (2017-05-15 20:06:35 UTC) #6
Eugene But (OOO till 7-30)
lgtm
3 years, 7 months ago (2017-05-15 22:29:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884043002/1
3 years, 7 months ago (2017-05-15 23:34:30 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 23:52:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/680ec74a33fcffefd0b1ed6a3968...

Powered by Google App Engine
This is Rietveld 408576698