Issue 2884023002: Fix analyzer tests in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2884023002: Fix analyzer tests in checked mode. (Closed)

Created:
3 years, 7 months ago by aam

Modified:
3 years, 7 months ago

Reviewers:
Paul Berry, scheglov

CC:
dart-fe-team+reviews_google.com, reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -2 lines)			Patch
M	pkg/front_end/lib/src/fasta/fasta.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/vm.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/kernel-service/kernel-service.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

aam

The breakage was introduced in https://codereview.chromium.org/2880453005.

3 years, 7 months ago (2017-05-15 17:18:18 UTC) #2

aam

Committed patchset #1 (id:1) manually as b0c6a5973186e542d9aa0cf5ad0725ef6302ad3d (presubmit successful).

3 years, 7 months ago (2017-05-15 17:26:07 UTC) #6

Message was sent while issue was closed.

LGTM