Build up and pass MemoryFileSystem to fasta frontend.

Build up and pass MemoryFileSystem to fasta frontend.

Allow kernel service request to provide source files(filename, content), which will be used to build up MemoryFileSystem instance. MemoryFileSystem instance will be used instead of PhysicalFileSystem instance.

Immediate need for this is to support VM unit testing, where small Dart scripts that have to be parsed are hardcoded in the unit tests.

BUG=https://github.com/dart-lang/sdk/issues/28264
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/089a355766d14c4b804c643fd927518387e25a9e

[aam, 2017-05-11 18:37:33]

aam@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com, scheglov@google.com

[aam, 2017-05-11 18:37:34]

Hi folks, here are the changes I mentioned in the email few days ago.

Please take a look, thanks!

[Paul Berry, 2017-05-11 21:11:53]

https://codereview.chromium.org/2880453005/diff/40001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2880453005/diff/40001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:101: // can be used instead of
PhysicalFileSystem.instance by the frontend.
Would it be better for the VM to pass this in as an interleaved list of file
path (string), raw file contents (Uint8List)?  Then we could use
.writeAsBytesSync() below and avoid the overhead of converting from UTF8 back to
bytes.

[aam, 2017-05-11 23:02:59]

https://codereview.chromium.org/2880453005/diff/40001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2880453005/diff/40001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:101: // can be used instead of
PhysicalFileSystem.instance by the frontend.
On 2017/05/11 21:11:53, Paul Berry wrote:
> Would it be better for the VM to pass this in as an interleaved list of file
> path (string), raw file contents (Uint8List)?  Then we could use
> .writeAsBytesSync() below and avoid the overhead of converting from UTF8 back
to
> bytes.

Okay, done.

I don't have strong opinion on this. On one hand performance is always a good
thing. But this is not supposed to be used for large files. List<String> rather
than list of raw bytes to me sounds like more natural way to represent source
code. Also having variables of different type in the List also feels somehow
weird.

[scheglov, 2017-05-12 00:48:59]

lgtm

https://codereview.chromium.org/2880453005/diff/60001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2880453005/diff/60001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:105: for (int i = 0; i <
namedSources.length / 2; i++) {
namedSources.length ~/ 2

[aam, 2017-05-12 22:11:19]

Thank you, Konstantin.

PTAL - I had to update vm.dart#_findPackagesFile so it also uses FileSystem
instance when it's looking for .packages file.

https://codereview.chromium.org/2880453005/diff/60001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2880453005/diff/60001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:105: for (int i = 0; i <
namedSources.length / 2; i++) {
On 2017/05/12 00:48:59, scheglov wrote:
> namedSources.length ~/ 2

Done.

[aam, 2017-05-12 23:24:26]

Description was changed from

==========
Build up and pass MemoryFileSystem to fasta frontend.

Allow kernel service request to provide source files(filename, content), which
will be used to build up MemoryFileSystem instance. MemoryFileSystem instance
will be used instead of PhysicalFileSystem instance.

Immediate need for this is to support VM unit testing, where small Dart scripts
that have to be parsed are hardcoded in the unit tests.

BUG=
==========

to

==========
Build up and pass MemoryFileSystem to fasta frontend.

Allow kernel service request to provide source files(filename, content), which
will be used to build up MemoryFileSystem instance. MemoryFileSystem instance
will be used instead of PhysicalFileSystem instance.

Immediate need for this is to support VM unit testing, where small Dart scripts
that have to be parsed are hardcoded in the unit tests.

BUG=https://github.com/dart-lang/sdk/issues/28264
==========

[scheglov, 2017-05-13 23:57:44]

LGTM

[aam, 2017-05-15 15:44:41]

Description was changed from

==========
Build up and pass MemoryFileSystem to fasta frontend.

Allow kernel service request to provide source files(filename, content), which
will be used to build up MemoryFileSystem instance. MemoryFileSystem instance
will be used instead of PhysicalFileSystem instance.

Immediate need for this is to support VM unit testing, where small Dart scripts
that have to be parsed are hardcoded in the unit tests.

BUG=https://github.com/dart-lang/sdk/issues/28264
==========

to

==========
Build up and pass MemoryFileSystem to fasta frontend.

Allow kernel service request to provide source files(filename, content), which
will be used to build up MemoryFileSystem instance. MemoryFileSystem instance
will be used instead of PhysicalFileSystem instance.

Immediate need for this is to support VM unit testing, where small Dart scripts
that have to be parsed are hardcoded in the unit tests.

BUG=https://github.com/dart-lang/sdk/issues/28264
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/089a355766d14c4b804c643fd927518387e25a9e
==========

[aam, 2017-05-15 15:44:42]

Committed patchset #7 (id:120001) manually as
089a355766d14c4b804c643fd927518387e25a9e (presubmit successful).