Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2883993002: android: Add the target to toplevel Looper events in tracing, (Closed)

Created:
3 years, 7 months ago by Benoit L
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Add the target to toplevel Looper events in tracing. When tracing is enabled, toplevel Looper tasks come from Chrome and the system. Non-native tasks are a black box, as they only show up as "toplevel.dispatchMessage" in tracing. This commit adds the "target" of the looper task as a parameter in the trace. For instance (from a startup trace): - android.view.ViewRootImpl$ViewRootHandler - android.view.Choreographer$FrameHandler - android.os.AsyncTask$InternalHandler - com.google.android.gms.common.internal.s This allows to distinguish between framework time, Chrome's Java tasks and third-party libs (GMSCore above). About performance cost: - The Java string is already created by the framework code, we extract a substring of it. - A new parameter for each toplevel trace event. Review-Url: https://codereview.chromium.org/2883993002 Cr-Commit-Position: refs/heads/master@{#472043} Committed: https://chromium.googlesource.com/chromium/src/+/71be2dc15e6765170cbc0054bb12fec403b9bed3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M base/android/java/src/org/chromium/base/TraceEvent.java View 2 chunks +9 lines, -2 lines 0 comments Download
M base/android/trace_event_binding.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Benoit L
3 years, 7 months ago (2017-05-15 16:02:52 UTC) #5
agrieve
love it! lgtm
3 years, 7 months ago (2017-05-15 17:55:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883993002/1
3 years, 7 months ago (2017-05-16 08:30:26 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 08:36:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71be2dc15e6765170cbc0054bb12...

Powered by Google App Engine
This is Rietveld 408576698