Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2883983005: Only enable copy options before FRE is completed on Android. (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
Reviewers:
Theresa, ltian
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only enable copy options before FRE is completed on Android. BUG=722320, 722307 Review-Url: https://codereview.chromium.org/2883983005 Cr-Commit-Position: refs/heads/master@{#472275} Committed: https://chromium.googlesource.com/chromium/src/+/45aa399675a3ad420c2b20817e866176863965fc

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update tests to cover all context menu modes (required no prod code changes) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -21 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 6 chunks +37 lines, -20 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java View 1 2 1 chunk +162 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Ted C
PTAL
3 years, 7 months ago (2017-05-16 00:00:47 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-05-16 00:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883983005/40001
3 years, 7 months ago (2017-05-16 17:55:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/446065)
3 years, 7 months ago (2017-05-16 21:05:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883983005/40001
3 years, 7 months ago (2017-05-16 21:48:14 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 01:00:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/45aa399675a3ad420c2b20817e86...

Powered by Google App Engine
This is Rietveld 408576698