Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2883983003: Revert of [tools/perf] Disable browse:social:twitter on mac (Closed)

Created:
3 years, 7 months ago by perezju
Modified:
3 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tools/perf] Disable browse:social:twitter on mac (patchset #1 id:1 of https://codereview.chromium.org/2886463002/ ) Reason for revert: Breaking change got reverted at: https://chromium-review.googlesource.com/c/505649/ Original issue's description: > [tools/perf] Disable browse:social:twitter on mac > > Benchmark is failing on Mac bots. > > TBR=nednguyen@google.com > BUG=722094 > > Review-Url: https://codereview.chromium.org/2886463002 > Cr-Commit-Position: refs/heads/master@{#471757} > Committed: https://chromium.googlesource.com/chromium/src/+/5d406d88f635955f2ab90a1832cb0cd3dc86591c TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=722094 Review-Url: https://codereview.chromium.org/2883983003 Cr-Commit-Position: refs/heads/master@{#471782} Committed: https://chromium.googlesource.com/chromium/src/+/69c298a0367624b2412314b0c49bc6f0024f5f8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
perezju
Created Revert of [tools/perf] Disable browse:social:twitter on mac
3 years, 7 months ago (2017-05-15 16:16:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883983003/1
3 years, 7 months ago (2017-05-15 16:17:07 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 16:17:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69c298a0367624b2412314b0c49b...

Powered by Google App Engine
This is Rietveld 408576698