Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2883963004: Revert of [Sheriff] Followup a revert ; update BUILD.gn (Closed)

Created:
3 years, 7 months ago by peria
Modified:
3 years, 7 months ago
Reviewers:
haraken, sashab
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, blink-reviews, nektarios, je_julie, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sheriff] Followup a revert ; update BUILD.gn (patchset #1 id:1 of https://codereview.chromium.org/2881093004/ ) Reason for revert: The broken tree was fixed by another change. This CL is not needed. Original issue's description: > This is a follow-up CL of https://codereview.chromium.org/2883203002 > > BUILD.gn was not updated. > > > TBR=sashab@chromium.org,aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=715382 > > Review-Url: https://codereview.chromium.org/2881093004 > Cr-Commit-Position: refs/heads/master@{#471982} > Committed: https://chromium.googlesource.com/chromium/src/+/003d66dbf407abf317a5bcfc7ebcbf5c2daa1c59 TBR=sashab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715382 Review-Url: https://codereview.chromium.org/2883963004 Cr-Commit-Position: refs/heads/master@{#471984} Committed: https://chromium.googlesource.com/chromium/src/+/2b9536581f36776f9a9cc13462d4d7f369686734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/accessibility/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
peria
Created Revert of [Sheriff] Followup a revert ; update BUILD.gn
3 years, 7 months ago (2017-05-16 02:19:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883963004/1
3 years, 7 months ago (2017-05-16 02:20:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2b9536581f36776f9a9cc13462d4d7f369686734
3 years, 7 months ago (2017-05-16 02:21:05 UTC) #6
haraken
3 years, 7 months ago (2017-05-16 02:30:07 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698