Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2883883002: [turbofan] Properly merge compatible field access infos. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly merge compatible field access infos. For a polymorphic access to o.x we would only merge it into a single PropertyAccessInfo so far, if x is at the same offset in all maps and the property index of x (in the descriptor arrays) is the same. But that doesn't matter for code generation and blocks optimizations even. BUG=v8:6278, v8:6344, v8:6396 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2883883002 Cr-Commit-Position: refs/heads/master@{#45294} Committed: https://chromium.googlesource.com/v8/v8/+/130d7dc34cc2281a7d940edc901fb0fc8c88095f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/compiler/access-info.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 7 months ago (2017-05-15 08:25:36 UTC) #1
Jarin
lgtm
3 years, 7 months ago (2017-05-15 08:40:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883883002/1
3 years, 7 months ago (2017-05-15 09:02:25 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 09:04:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/130d7dc34cc2281a7d940edc901fb0fc8c8...

Powered by Google App Engine
This is Rietveld 408576698