Adjust position of separator in location bar.

Adjust position of separator in location bar.

The separator is positioned based on the layout of the label. Previously
we forgot to account for the width of the separator when laying out the
label, so in effect the label was 1dip too wide and the separator was
1dip too far to the right.

This only affects DSFs <2.

BUG=721741
Review-Url: https://codereview.chromium.org/2883843004
Cr-Commit-Position: refs/heads/master@{#472153}
Committed: https://chromium.googlesource.com/chromium/src/+/959d42beb82698415e47bfde4fc791e56aa422ed

[Evan Stade, 2017-05-16 00:14:44]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2017-05-16 00:52:52]

LGTM

https://codereview.chromium.org/2883843004/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/icon_label_bubble_view.h (right):

https://codereview.chromium.org/2883843004/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/icon_label_bubble_view.h:106: int
GetSeparatorLayoutWidth() const;
Nit: Maybe should be listed before GetPostSeparatorPadding()?

[Evan Stade, 2017-05-16 16:30:03]

https://codereview.chromium.org/2883843004/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/icon_label_bubble_view.h (right):

https://codereview.chromium.org/2883843004/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/icon_label_bubble_view.h:106: int
GetSeparatorLayoutWidth() const;
On 2017/05/16 00:52:52, Peter Kasting wrote:
> Nit: Maybe should be listed before GetPostSeparatorPadding()?

Done.

[Evan Stade, 2017-05-16 16:30:25]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-16 16:30:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2883843004/#ps20001
(title: "fn order")

[commit-bot: I haz the power, 2017-05-16 16:31:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 17:57:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494952225340230,
"parent_rev": "2fa0d466bdbd2b52ba16ad9435a2f93d7f4084a5", "commit_rev":
"959d42beb82698415e47bfde4fc791e56aa422ed"}

[commit-bot: I haz the power, 2017-05-16 17:57:34]

Description was changed from

==========
Adjust position of separator in location bar.

The separator is positioned based on the layout of the label. Previously
we forgot to account for the width of the separator when laying out the
label, so in effect the label was 1dip too wide and the separator was
1dip too far to the right.

This only affects DSFs <2.

BUG=721741
==========

to

==========
Adjust position of separator in location bar.

The separator is positioned based on the layout of the label. Previously
we forgot to account for the width of the separator when laying out the
label, so in effect the label was 1dip too wide and the separator was
1dip too far to the right.

This only affects DSFs <2.

BUG=721741

Review-Url: https://codereview.chromium.org/2883843004
Cr-Commit-Position: refs/heads/master@{#472153}
Committed:
https://chromium.googlesource.com/chromium/src/+/959d42beb82698415e47bfde4fc7...
==========

[commit-bot: I haz the power, 2017-05-16 17:57:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/959d42beb82698415e47bfde4fc7...