Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2883843002: Add more WebAPK install metrics (Closed)

Created:
3 years, 7 months ago by pkotwicz
Modified:
3 years, 6 months ago
Reviewers:
Xi Han, Yaron, Ilya Sherman
CC:
chromium-reviews, zpeng+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more WebAPK install metrics This CL adds metrics for: - The duration of the processing prior to binding to the Play Install service. This includes computing the icon hashes and requesting the token from the WebAPK server. - The amount of time that binding to the Play Install service takes BUG=722178 Review-Url: https://codereview.chromium.org/2883843002 Cr-Commit-Position: refs/heads/master@{#474287} Committed: https://chromium.googlesource.com/chromium/src/+/1d9e46d37881ab3479d625ed0c9170e1d93f2605

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into slow_metrics #

Patch Set 3 : Merge branch 'master' into slow_metrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java View 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/webapk/webapk_metrics.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/webapk/webapk_metrics.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
pkotwicz
Xi, can you please take a look?
3 years, 7 months ago (2017-05-15 04:54:51 UTC) #2
pkotwicz
Xi Ping!
3 years, 7 months ago (2017-05-17 20:42:00 UTC) #3
Xi Han
lgtm
3 years, 7 months ago (2017-05-17 21:32:02 UTC) #4
Yaron
lgtm
3 years, 7 months ago (2017-05-19 20:53:05 UTC) #6
pkotwicz
isherman@ for histograms.xml
3 years, 7 months ago (2017-05-23 19:45:51 UTC) #8
Ilya Sherman
Metrics lgtm
3 years, 7 months ago (2017-05-23 21:29:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883843002/40001
3 years, 7 months ago (2017-05-23 21:58:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/301081)
3 years, 7 months ago (2017-05-24 02:50:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883843002/40001
3 years, 6 months ago (2017-05-24 14:04:12 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-05-24 14:52:45 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1d9e46d37881ab3479d625ed0c91...

Powered by Google App Engine
This is Rietveld 408576698