Issue 2883833002: net: Do not sniff XHTML content

tkent

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-15 03:40:18 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883833002/1

3 years, 7 months ago (2017-05-15 03:40:26 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 7 months ago (2017-05-15 04:07:38 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/214618)

3 years, 7 months ago (2017-05-15 04:07:39 UTC) #4

tkent

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-15 04:27:36 UTC) #5

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883833002/20001

3 years, 7 months ago (2017-05-15 04:27:44 UTC) #6

tkent

Description was changed from ========== net: Do not alter MIME type for application/xml + XHTML ...

3 years, 7 months ago (2017-05-15 04:27:57 UTC) #7

tkent

Description was changed from ========== net: Do not alter MIME type for application/xml + XHTML ...

3 years, 7 months ago (2017-05-15 05:21:33 UTC) #9

tkent

Description was changed from ========== net: Do not alter MIME type for application/xml + XHTML ...

3 years, 7 months ago (2017-05-15 05:25:28 UTC) #10

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 7 months ago (2017-05-15 06:18:59 UTC) #11

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

3 years, 7 months ago (2017-05-15 06:19:00 UTC) #12

tkent

tkent@chromium.org changed reviewers: + mmenke@chromium.org

3 years, 7 months ago (2017-05-15 07:25:31 UTC) #13

tkent

mmenke@, would you review this please? https://codereview.chromium.org/2883833002/diff/20001/net/base/mime_sniffer.cc File net/base/mime_sniffer.cc (right): https://codereview.chromium.org/2883833002/diff/20001/net/base/mime_sniffer.cc#newcode549 net/base/mime_sniffer.cc:549: MAGIC_STRING("application/xhtml+xml", I think ...

3 years, 7 months ago (2017-05-15 07:25:32 UTC) #14

tkent

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-16 00:53:25 UTC) #15

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883833002/40001

3 years, 7 months ago (2017-05-16 00:55:09 UTC) #16

tkent

Description was changed from ========== net: Do not alter MIME type for application/xml + XHTML ...

3 years, 7 months ago (2017-05-16 01:03:54 UTC) #17

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 7 months ago (2017-05-16 02:10:14 UTC) #19

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455327)

3 years, 7 months ago (2017-05-16 02:10:15 UTC) #20

mmenke

On 2017/05/16 01:04:27, tkent wrote: > Updated the patch to remove XHTML content sniff entirely. ...

3 years, 7 months ago (2017-05-17 14:13:52 UTC) #21

mmenke

Sorry again for the delay - the renderer's handling of mime types is basically a ...

3 years, 7 months ago (2017-05-17 20:51:42 UTC) #22

tkent

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-19 00:46:39 UTC) #23

tkent

Description was changed from ========== net: Do not sniff XHTML content This CL removes XHTML ...

3 years, 7 months ago (2017-05-19 00:47:23 UTC) #24

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883833002/60001

3 years, 7 months ago (2017-05-19 00:47:38 UTC) #25

tkent

Description was changed from ========== net: Do not sniff XHTML content This CL removes XHTML ...

3 years, 7 months ago (2017-05-19 00:55:00 UTC) #26

tkent

Thank you for your review! https://codereview.chromium.org/2883833002/diff/40001/net/base/mime_sniffer_unittest.cc File net/base/mime_sniffer_unittest.cc (right): https://codereview.chromium.org/2883833002/diff/40001/net/base/mime_sniffer_unittest.cc#newcode360 net/base/mime_sniffer_unittest.cc:360: SniffMimeType("<foo><html xmlns=\"http://www.w3.org/1999/xhtml\">", On 2017/05/17 ...

3 years, 7 months ago (2017-05-19 00:55:42 UTC) #27

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 7 months ago (2017-05-19 05:46:09 UTC) #28

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

3 years, 7 months ago (2017-05-19 05:46:10 UTC) #29

mmenke

net/ LGTM. You should have someone familiar with layout tests review those changes - I'm ...

3 years, 7 months ago (2017-05-22 15:40:34 UTC) #30

tkent

tkent@chromium.org changed reviewers: + yosin@chromium.org

3 years, 7 months ago (2017-05-23 00:24:52 UTC) #31

tkent

yosin@, would you check LayoutTests changes please? I'm confident that these changes are valid.

3 years, 7 months ago (2017-05-23 00:26:02 UTC) #32

tkent

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-23 00:26:12 UTC) #33

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883833002/60001

3 years, 7 months ago (2017-05-23 00:27:03 UTC) #34

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883833002/60001

3 years, 7 months ago (2017-05-23 01:08:31 UTC) #38

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495501672977090, "parent_rev": "6df0b5c128f7ebfe6c6cc3b8bd496ea3e13fa8cc", "commit_rev": "9cc9427a4b67b394747dde2f1b8279a0d3384892"}

3 years, 7 months ago (2017-05-23 04:08:04 UTC) #39

commit-bot: I haz the power

Description was changed from ========== net: Do not sniff XHTML content This CL removes XHTML ...

3 years, 7 months ago (2017-05-23 04:08:19 UTC) #40

Message was sent while issue was closed.

Description was changed from

==========
net: Do not sniff XHTML content

This CL removes XHTML content sniff for text/xml and application/xml.

We altered the content-type to application/xhtml+xml if the root tag starts with
the following:

<html xmlns="http://www.w3.org/1999/xhtml"

We stop it.
This behavior has never been applied to

<html xmlns='http://www.w3.org/1999/xhtml'
or
<html  xmlns="http://www.w3.org/1999/xhtml"

because this behavior was introduced to pass some layout tests.

The behavior difference between application/xml and application/xhtml+xml is
document.createElement().  This CL updates some tests.
New behavior is interoperable with Edge, Firefox, and Safari.

* LayoutTests changes
** external/wpt/dom/nodes/Document-createElement-namespace.html
  This CL fixes failing sub-tests.
** fast/dom/Document/xml-document-focus.xml
  Page rendering is changed because of document.createElement() in js-test.js.
** fast/dom/ping-attribute-no-crash.xml
  This assumes document.createElement() has XHTML behavior. This CL renames it
  to html/text_level_semantics/a-ping-no-crash.xhtml.
** http/tests/misc/createElementNamespace1.xml
  This CL fixes a failing sub-test about document.createElement().

BUG=231927, 702084
==========

to

==========
net: Do not sniff XHTML content

This CL removes XHTML content sniff for text/xml and application/xml.

We altered the content-type to application/xhtml+xml if the root tag starts with
the following:

<html xmlns="http://www.w3.org/1999/xhtml"

We stop it.
This behavior has never been applied to

<html xmlns='http://www.w3.org/1999/xhtml'
or
<html  xmlns="http://www.w3.org/1999/xhtml"

because this behavior was introduced to pass some layout tests.

The behavior difference between application/xml and application/xhtml+xml is
document.createElement().  This CL updates some tests.
New behavior is interoperable with Edge, Firefox, and Safari.

* LayoutTests changes
** external/wpt/dom/nodes/Document-createElement-namespace.html
  This CL fixes failing sub-tests.
** fast/dom/Document/xml-document-focus.xml
  Page rendering is changed because of document.createElement() in js-test.js.
** fast/dom/ping-attribute-no-crash.xml
  This assumes document.createElement() has XHTML behavior. This CL renames it
  to html/text_level_semantics/a-ping-no-crash.xhtml.
** http/tests/misc/createElementNamespace1.xml
  This CL fixes a failing sub-test about document.createElement().

BUG=231927, 702084

Review-Url: https://codereview.chromium.org/2883833002
Cr-Commit-Position: refs/heads/master@{#473805}
Committed:
https://chromium.googlesource.com/chromium/src/+/9cc9427a4b67b394747dde2f1b82...
==========

commit-bot: I haz the power

3 years, 7 months ago (2017-05-23 04:08:20 UTC) #41

Message was sent while issue was closed.

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9cc9427a4b67b394747dde2f1b82...

Issue 2883833002: net: Do not sniff XHTML content (Closed)

Description

Patch Set 1 : . #

Patch Set 2 : Remove XHTML content sniff entirely #

Patch Set 3 : Update tests #

Messages