|
Reland of name AXObject to AXObjectImpl in modules/ and web/ (patchset #1 id:1 of https://codereview.chromium.org/2883203002/ )
Reason for revert:
Lots of breakage across all CQ builders e.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/454351
Looks like the revert is missing a BUILD.gn update at least
Original issue's description:
> Revert of Rename AXObject to AXObjectImpl in modules/ and web/ (patchset #9 id:160001 of https://codereview.chromium.org/2858493002/ )
>
> Reason for revert:
> Landed wrong patchset.
>
> Original issue's description:
> > Rename AXObject to AXObjectImpl in modules/ and web/
> >
> > Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an
> > empty abstract parent class in core/. This is pre-work to remove usages
> > of AXObjectImpl from web/, which will use AXObject instead.
> >
> > This patch does not rename the usages in core/ since these should use
> > the new abstract object.
> >
> > BUG= 715382
> >
> > Review-Url: https://codereview.chromium.org/2858493002
> > Cr-Commit-Position: refs/heads/master@{#471663}
> > Committed: https://chromium.googlesource.com/chromium/src/+/234813ae8d52f622a1664e11365642751e8f26ba
>
> TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 715382
>
> Review-Url: https://codereview.chromium.org/2883203002
> Cr-Commit-Position: refs/heads/master@{#471975}
> Committed: https://chromium.googlesource.com/chromium/src/+/b88633c21b9db5ffcb316d744452625ccb5061e9
TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 715382
Review-Url: https://codereview.chromium.org/2883813005
Cr-Commit-Position: refs/heads/master@{#471980}
Committed: https://chromium.googlesource.com/chromium/src/+/f393a79bfdbef6b60a59d362456a77f69e9da920
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+3482 lines, -3444 lines) |
Patch |
 |
M |
docs/accessibility/overview.md
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/display-none-change.html
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt
|
View
|
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/AXObjectCache.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Document.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/FrameView.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/HTMLInputElement.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/HTMLInputElement.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/ColorChooser.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/ColorInputType.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/DateTimeChooser.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/InputTypeView.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/InputTypeView.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/ChromeClient.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/PagePopup.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
|
View
|
|
4 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
|
View
|
|
8 chunks |
+13 lines, -11 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
|
View
|
|
6 chunks |
+16 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
|
View
|
|
50 chunks |
+69 lines, -64 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXListBox.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMediaControls.h
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
|
View
|
|
4 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMockObject.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
|
View
|
|
6 chunks |
+17 lines, -17 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
|
View
|
|
54 chunks |
+88 lines, -84 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/modules/accessibility/AXObject.h
|
View
|
|
1 chunk |
+0 lines, -1138 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/modules/accessibility/AXObject.cpp
|
View
|
|
1 chunk |
+0 lines, -1871 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
|
View
|
|
10 chunks |
+35 lines, -35 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
|
View
|
|
52 chunks |
+89 lines, -84 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
|
View
|
|
1 chunk |
+1143 lines, -0 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
|
View
|
|
1 chunk |
+1884 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
|
View
|
|
2 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp
|
View
|
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXSlider.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXSpinButton.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|