Move detached files from web/ to (core/modules)/exported.

Move detached files from web/ to (core/modules)/exported.

This CL moves files from web/ that are implementations of classes defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/, otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which 
indicates that there should be no dependence on these methods externally.

BUG=712963
Review-Url: https://codereview.chromium.org/2883793003
Cr-Commit-Position: refs/heads/master@{#471700}
Committed: https://chromium.googlesource.com/chromium/src/+/3012c22bf47687f565edd7bd2697bb1bf155303c

[slangley, 2017-05-15 04:42:49]

Description was changed from

==========
Move detached files from web/ to (core/modules)/exported.

BUG=
==========

to

==========
Move detached files from web/ to (core/modules)/exported.

This CL starts moving files from web/ that are implementations of classes
defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/,
otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions
in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which 
indicates that there should be no dependence on these methods externally.

BUG=712963
==========

[slangley, 2017-05-15 04:42:49]

slangley@chromium.org changed reviewers:
+ dcheng@chromium.org

[slangley, 2017-05-15 04:43:12]

Description was changed from

==========
Move detached files from web/ to (core/modules)/exported.

This CL starts moving files from web/ that are implementations of classes
defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/,
otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions
in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which 
indicates that there should be no dependence on these methods externally.

BUG=712963
==========

to

==========
Move detached files from web/ to (core/modules)/exported.

This CL moves files from web/ that are implementations of classes defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/,
otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions
in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which 
indicates that there should be no dependence on these methods externally.

BUG=712963
==========

[haraken, 2017-05-15 04:53:39]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-05-15 04:53:40]

LGTM

https://codereview.chromium.org/2883793003/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebRange.h (right):

https://codereview.chromium.org/2883793003/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebRange.h:61: BLINK_EXPORT EphemeralRange
CreateEphemeralRange(LocalFrame*) const;

I'm just curious but when do we need to add BLINK_EXPORT?

[slangley, 2017-05-15 05:02:24]

On 2017/05/15 at 04:53:40, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/2883793003/diff/1/third_party/WebKit/public/w...
> File third_party/WebKit/public/web/WebRange.h (right):
> 
>
https://codereview.chromium.org/2883793003/diff/1/third_party/WebKit/public/w...
> third_party/WebKit/public/web/WebRange.h:61: BLINK_EXPORT EphemeralRange
CreateEphemeralRange(LocalFrame*) const;
> 
> I'm just curious but when do we need to add BLINK_EXPORT?

When the caller is still in web/ - Previously these worked as the caller was in
the same link unit. Ultimately once all of the files are moved to core or
modules many of these BLINK_EXPORTs could be removed.

[slangley, 2017-05-15 05:02:44]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-15 05:02:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 08:41:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494824564042970, "parent_rev":
"a72075abe9fe56104e33384f5876daa42a946a42", "commit_rev":
"3012c22bf47687f565edd7bd2697bb1bf155303c"}

[commit-bot: I haz the power, 2017-05-15 08:41:49]

Description was changed from

==========
Move detached files from web/ to (core/modules)/exported.

This CL moves files from web/ that are implementations of classes defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/,
otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions
in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which 
indicates that there should be no dependence on these methods externally.

BUG=712963
==========

to

==========
Move detached files from web/ to (core/modules)/exported.

This CL moves files from web/ that are implementations of classes defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/,
otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions
in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which 
indicates that there should be no dependence on these methods externally.

BUG=712963

Review-Url: https://codereview.chromium.org/2883793003
Cr-Commit-Position: refs/heads/master@{#471700}
Committed:
https://chromium.googlesource.com/chromium/src/+/3012c22bf47687f565edd7bd2697...
==========

[commit-bot: I haz the power, 2017-05-15 08:41:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3012c22bf47687f565edd7bd2697...