build/secondary/third_party/android_platform/development/scripts/BUILD.gn - Issue 2883633003: Enable store tombstones for swarming bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/android_platform/development/scripts/BUILD.gn

Issue 2883633003: Enable store tombstones for swarming bots. (Closed)

Patch Set: fixes Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/secondary/third_party/android_platform/development/scripts/BUILD.gn

diff --git a/build/secondary/third_party/android_platform/development/scripts/BUILD.gn b/build/secondary/third_party/android_platform/development/scripts/BUILD.gn

index 6dabf5ed50e22552816a789f49c4e668fc6145b6..9cd8b9800eecc1f0b2934808e58d2d487f2bf65c 100644

--- a/build/secondary/third_party/android_platform/development/scripts/BUILD.gn

+++ b/build/secondary/third_party/android_platform/development/scripts/BUILD.gn

@@ -10,4 +10,9 @@ group("stack_py") {

set_sources_assignment_filter([ "#*" ])

sources = _py_files

data = sources

+ import("//build/config/android/config.gni")

jbudorick 2017/05/17 16:30:40 nit: move this outside of the stack_py definition

BigBossZhiling 2017/05/17 21:28:12 Done.

+ data += ["${android_tool_prefix}addr2line",

jbudorick 2017/05/17 16:30:40 Nice find! This is much better than my suggestion

BigBossZhiling 2017/05/17 21:28:12 Acknowledged.

+ "${android_tool_prefix}objdump",

+ "${android_tool_prefix}c++filt"]

}