Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate

Issue 2883623004: fix KeyEvent and KeyboardEvent (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate
diff --git a/tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate b/tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate
index 0cea80315ffda61971fa7536c137e6a7c0254de8..408c641ac195d45c93041ea51d4df7389da3ce9f 100644
--- a/tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate
+++ b/tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate
@@ -26,20 +26,20 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS
*/
factory $CLASSNAME(String type,
{Window view, bool canBubble: true, bool cancelable: true,
- int keyLocation: 1, bool ctrlKey: false,
+ int location: 1, bool ctrlKey: false,
Jacob 2017/05/12 23:28:18 We shouldn't be making breaking changes to the Dar
bool altKey: false, bool shiftKey: false, bool metaKey: false}) {
if (view == null) {
view = window;
}
KeyboardEvent e = document._createEvent("KeyboardEvent");
e._initKeyboardEvent(type, canBubble, cancelable, view, "",
- keyLocation, ctrlKey, altKey, shiftKey, metaKey);
+ location, ctrlKey, altKey, shiftKey, metaKey);
return e;
}
@DomName('KeyboardEvent.initKeyboardEvent')
void _initKeyboardEvent(String type, bool canBubble, bool cancelable,
- Window view, String keyIdentifier, int keyLocation, bool ctrlKey,
+ Window view, String keyIdentifier, int location, bool ctrlKey,
bool altKey, bool shiftKey, bool metaKey) {
if (JS('bool', 'typeof(#.initKeyEvent) == "function"', this)) {
// initKeyEvent is only in Firefox (instead of initKeyboardEvent). It has
@@ -52,7 +52,7 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS
} else {
// initKeyboardEvent is for all other browsers.
JS('void', '#.initKeyboardEvent(#, #, #, #, #, #, #, #, #, #)', this,
- type, canBubble, cancelable, view, keyIdentifier, keyLocation,
+ type, canBubble, cancelable, view, keyIdentifier, location,
ctrlKey, altKey, shiftKey, metaKey);
}
}
« no previous file with comments | « tools/dom/src/dart2js_KeyEvent.dart ('k') | tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698