Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2883593002: Add frame count to paint image. (Closed)

Created:
3 years, 7 months ago by vmpstr
Modified:
3 years, 6 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, dcheng, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add frame count to paint image. This patch adds the number of frames in the image to PaintImage. R=chrishtr@chromium.org BUG=693968 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2883593002 Cr-Commit-Position: refs/heads/master@{#477168} Committed: https://chromium.googlesource.com/chromium/src/+/05729e73de37e9f74e80e1009350422142b7aae5

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Patch Set 3 : undo extra uploads #

Patch Set 4 : update #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M cc/paint/paint_image.h View 1 2 3 4 2 chunks +13 lines, -1 line 0 comments Download
M cc/paint/paint_image.cc View 1 2 3 4 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/DragImage.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.h View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
vmpstr
Please take a look.
3 years, 7 months ago (2017-05-12 20:27:12 UTC) #3
chrishtr
https://codereview.chromium.org/2883593002/diff/1/cc/paint/paint_image.h File cc/paint/paint_image.h (right): https://codereview.chromium.org/2883593002/diff/1/cc/paint/paint_image.h#newcode62 cc/paint/paint_image.h:62: // The number of frames in this image; 0 ...
3 years, 7 months ago (2017-05-12 22:08:56 UTC) #4
vmpstr
It's the number of frames in an animated image (like a GIF). I've updated the ...
3 years, 7 months ago (2017-05-12 22:21:57 UTC) #5
chrishtr
lgtm
3 years, 6 months ago (2017-06-01 00:48:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883593002/80001
3 years, 6 months ago (2017-06-05 22:23:38 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 03:07:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/05729e73de37e9f74e80e1009350...

Powered by Google App Engine
This is Rietveld 408576698