third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h - Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

Issue 2883503004: [DMC #7] Only create RenderedDocumentMarkers for TextMatchMarkerListImpl (Closed)

Patch Set: Rebase on InvalidateRectsForAllMarkers() refactor Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

index bd3308cdf3054140632fb1c76d2d22ab29738359..457507e2390bcc042ab0cb26a80fb635dc7782bf 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

@@ -11,7 +11,7 @@

namespace blink {

-class RenderedDocumentMarker;

+class DocumentMarker;

// This is an interface implemented by classes that DocumentMarkerController

// uses to store DocumentMarkers. Different implementations can be written

@@ -31,8 +31,7 @@ class CORE_EXPORT DocumentMarkerList

virtual void Add(DocumentMarker*) = 0;

virtual void Clear() = 0;

- virtual const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers()

- const = 0;

+ virtual const HeapVector<Member<DocumentMarker>>& GetMarkers() const = 0;

// Returns true if at least one marker is copied, false otherwise

virtual bool MoveMarkers(int length, DocumentMarkerList* dst_list) = 0;