Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2883503002:
Use TaskScheduler instead of SequencedWorkerPool in task_manager_impl.cc. (Closed)
|
Created:
3 years, 7 months ago by fdoray Modified:
3 years, 7 months ago Reviewers:
ncarter (slow) CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TaskScheduler instead of SequencedWorkerPool in task_manager_impl.cc.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
R=nick@chromium.org
Review-Url: https://codereview.chromium.org/2883503002
Cr-Commit-Position: refs/heads/master@{#473703}
Committed: https://chromium.googlesource.com/chromium/src/+/fc395879fe38b3a86febe1dfc38e72d271801398
Patch Set 1 #
Total comments: 2
Patch Set 2 : CR-ncarter-7 #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Please take a look. This CL was generated automatically. The base::MayBlock() trait was specified for all call sites and the base::TaskPriority::BACKGROUND trait was specified for all non-test call sites. That may not be appropriate for your use case. Please verify that appropriate traits were used https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks. - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the shutdown behavior is not set explicitly (no base::TaskShutdownBehavior)? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. What if the task priority is not set explicitly (no base::TaskPriority)? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority).
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2883503002/diff/1/chrome/browser/task_manager... File chrome/browser/task_manager/sampling/task_manager_impl.cc (right): https://codereview.chromium.org/2883503002/diff/1/chrome/browser/task_manager... chrome/browser/task_manager/sampling/task_manager_impl.cc:45: {base::MayBlock(), base::TaskPriority::BACKGROUND})), I think SKIP_SHUTDOWN would be appropriate here. While TaskManager updates are potentially user-visible while the UI is displayed, we also have background data collection tasks that use this API, so I think keeping this at BACKGROUND priority is the right call.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAnL https://codereview.chromium.org/2883503002/diff/1/chrome/browser/task_manager... File chrome/browser/task_manager/sampling/task_manager_impl.cc (right): https://codereview.chromium.org/2883503002/diff/1/chrome/browser/task_manager... chrome/browser/task_manager/sampling/task_manager_impl.cc:45: {base::MayBlock(), base::TaskPriority::BACKGROUND})), On 2017/05/17 20:11:21, ncarter (slow) wrote: > I think SKIP_SHUTDOWN would be appropriate here. > > While TaskManager updates are potentially user-visible while the UI is > displayed, we also have background data collection tasks that use this API, so I > think keeping this at BACKGROUND priority is the right call. Done. Added this file to a list of files to refactor once TaskScheduler supports mutually exclusive sequences running at different priorities.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495485490807630,
"parent_rev": "27d00a1cc8265350d09f7eb9b434b0640de931ca", "commit_rev":
"fc395879fe38b3a86febe1dfc38e72d271801398"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of SequencedWorkerPool in task_manager_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=nick@chromium.org ========== to ========== Use TaskScheduler instead of SequencedWorkerPool in task_manager_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=nick@chromium.org Review-Url: https://codereview.chromium.org/2883503002 Cr-Commit-Position: refs/heads/master@{#473703} Committed: https://chromium.googlesource.com/chromium/src/+/fc395879fe38b3a86febe1dfc38e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fc395879fe38b3a86febe1dfc38e... |
