Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2883493002: Add UI to mass delete dead bots (Closed)

Created:
3 years, 7 months ago by kjlubick
Modified:
3 years, 7 months ago
Reviewers:
stephana, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add UI to mass delete dead bots This is largely based off the mass task cancellation from https://github.com/luci/luci-py/commit/524e4832 BUG=721470 Review-Url: https://codereview.chromium.org/2883493002 Committed: https://github.com/luci/luci-py/commit/e65fd342baf65cf37be35dd19e32c3b5b078d110

Patch Set 1 #

Patch Set 2 : Rest of bot-mass-delete seems to be ready #

Patch Set 3 : Tweak docs #

Patch Set 4 : Make status more robust to quarantined dimensions #

Total comments: 2

Patch Set 5 : Refresh list after Done is tapped #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -35 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 2 3 4 5 chunks +137 lines, -9 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-filters.html View 5 chunks +29 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 1 2 3 4 7 chunks +41 lines, -4 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-demo.html View 1 2 4 chunks +40 lines, -5 lines 0 comments Download
A appengine/swarming/ui/res/imp/botlist/bot-mass-delete.html View 1 2 1 chunk +200 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-filters.html View 2 chunks +9 lines, -9 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-mass-cancel.html View 1 2 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kjlubick
See a demo at https://screencast.googleplex.com/cast/NTY1NjM2Nzc0MjMyMDY0MHxiODhmZjdkMS05Mw
3 years, 7 months ago (2017-05-15 15:08:24 UTC) #3
M-A Ruel
On 2017/05/15 15:08:24, kjlubick wrote: > See a demo at > https://screencast.googleplex.com/cast/NTY1NjM2Nzc0MjMyMDY0MHxiODhmZjdkMS05Mw UI lgtm I ...
3 years, 7 months ago (2017-05-15 15:55:37 UTC) #4
stephana
https://codereview.chromium.org/2883493002/diff/60001/appengine/swarming/ui/res/imp/botlist/bot-list.html File appengine/swarming/ui/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2883493002/diff/60001/appengine/swarming/ui/res/imp/botlist/bot-list.html#newcode253 appengine/swarming/ui/res/imp/botlist/bot-list.html:253: <paper-dialog id="delete_all_dialog" modal> I agree, when this dialog closes ...
3 years, 7 months ago (2017-05-15 17:22:58 UTC) #5
kjlubick
https://codereview.chromium.org/2883493002/diff/60001/appengine/swarming/ui/res/imp/botlist/bot-list.html File appengine/swarming/ui/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2883493002/diff/60001/appengine/swarming/ui/res/imp/botlist/bot-list.html#newcode253 appengine/swarming/ui/res/imp/botlist/bot-list.html:253: <paper-dialog id="delete_all_dialog" modal> On 2017/05/15 at 17:22:58, stephana wrote: ...
3 years, 7 months ago (2017-05-15 17:48:09 UTC) #6
stephana
lgtm
3 years, 7 months ago (2017-05-15 17:59:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883493002/80001
3 years, 7 months ago (2017-05-15 18:08:33 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 18:12:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/e65fd342baf65cf37be35dd19e32c3b5b078d110

Powered by Google App Engine
This is Rietveld 408576698