Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2883473002: gn: fix bootstrap on windows (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: fix bootstrap on windows Review-Url: https://codereview.chromium.org/2883473002 Cr-Commit-Position: refs/heads/master@{#471320} Committed: https://chromium.googlesource.com/chromium/src/+/dfb837a97c2ee14bbcfb04a8bdd1a23813cab054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 9 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
It seems that not many people try to use this script on Windows...
3 years, 7 months ago (2017-05-12 15:24:08 UTC) #3
scottmg
shruggy-lgtm
3 years, 7 months ago (2017-05-12 15:25:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883473002/1
3 years, 7 months ago (2017-05-12 15:26:40 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 15:52:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfb837a97c2ee14bbcfb04a8bdd1...

Powered by Google App Engine
This is Rietveld 408576698